2009-06-25 20:48:22

by David Rientjes

Subject: [patch] mm: remove obsoleted alloc_pages cpuset comment

When a cpuset's nodemask is updated, all attached tasks have their cached
task->mems_allowed updated by a heap instead of requiring an explicit
call to cpuset_update_task_memory_state(), which has since been removed
in 58568d2a8215cb6f55caf2332017d7bdff954e1c.

Remove the obsoleted comment from the page allocator.

Cc: Paul Menage <[email protected]>
Cc: Miao Xie <[email protected]>
Signed-off-by: David Rientjes <[email protected]>
---
mm/page_alloc.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5d714f8..8670fb7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1620,10 +1620,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,

/* We now go into synchronous reclaim */
cpuset_memory_pressure_bump();
-
- /*
- * The task's cpuset might have expanded its set of allowable nodes
- */
p->flags |= PF_MEMALLOC;
lockdep_set_current_reclaim_state(gfp_mask);
reclaim_state.reclaimed_slab = 0;

2009-06-28 14:53:16

by Miao Xie

Subject: Re: [patch] mm: remove obsoleted alloc_pages cpuset comment

> When a cpuset's nodemask is updated, all attached tasks have their cached
> task->mems_allowed updated by a heap instead of requiring an explicit
> call to cpuset_update_task_memory_state(), which has since been removed
> in 58568d2a8215cb6f55caf2332017d7bdff954e1c.
>
> Remove the obsoleted comment from the page allocator.

Sorry. It's my mistake. Thanks for your fix.

Acked-by: Miao Xie <[email protected]>

>
> Cc: Paul Menage <[email protected]>
> Cc: Miao Xie <[email protected]>
> Signed-off-by: David Rientjes <[email protected]>
> ---
> mm/page_alloc.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5d714f8..8670fb7 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1620,10 +1620,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order,
>
> /* We now go into synchronous reclaim */
> cpuset_memory_pressure_bump();
> -
> - /*
> - * The task's cpuset might have expanded its set of allowable nodes
> - */
> p->flags |= PF_MEMALLOC;
> lockdep_set_current_reclaim_state(gfp_mask);
> reclaim_state.reclaimed_slab = 0;
>
>
>