Hi Philipp,
Today's linux-next build (powerpc allyesconfig) failed like this:
drivers/block/drbd/drbd_trace.o: In function `.roles_to_name':
(.text+0x64): multiple definition of `.roles_to_name'
drivers/block/drbd/drbd.o:(.text+0x28eb8): first defined here
drivers/block/drbd/drbd_trace.o: In function `disks_to_name':
(.opd+0x30): multiple definition of `disks_to_name'
drivers/block/drbd/drbd.o:(.opd+0x1b78): first defined here
drivers/block/drbd/drbd_trace.o: In function `roles_to_name':
(.opd+0x18): multiple definition of `roles_to_name'
drivers/block/drbd/drbd.o:(.opd+0x1b60): first defined here
drivers/block/drbd/drbd_trace.o: In function `.conns_to_name':
(.text+0x0): multiple definition of `.conns_to_name'
drivers/block/drbd/drbd.o:(.text+0x28e54): first defined here
drivers/block/drbd/drbd_trace.o: In function `set_st_err_name':
(.opd+0x48): multiple definition of `set_st_err_name'
drivers/block/drbd/drbd.o:(.opd+0x1b90): first defined here
drivers/block/drbd/drbd_trace.o: In function `.disks_to_name':
(.text+0xcc): multiple definition of `.disks_to_name'
drivers/block/drbd/drbd.o:(.text+0x28f20): first defined here
drivers/block/drbd/drbd_trace.o: In function `conns_to_name':
(.opd+0x0): multiple definition of `conns_to_name'
drivers/block/drbd/drbd.o:(.opd+0x1b48): first defined here
drivers/block/drbd/drbd_trace.o: In function `.set_st_err_name':
(.text+0x134): multiple definition of `.set_st_err_name'
drivers/block/drbd/drbd.o:(.text+0x28f88): first defined here
I applied the following patch to mark DRBD_TRACE broken for now.
--
Cheers,
Stephen Rothwell [email protected]
From: Stephen Rothwell <[email protected]>
Date: Mon, 27 Jul 2009 17:27:39 +1000
Subject: [PATCH] drbd: tracing is broken
Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/block/drbd/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig
index 8b14ea2..b047662 100644
--- a/drivers/block/drbd/Kconfig
+++ b/drivers/block/drbd/Kconfig
@@ -41,6 +41,7 @@ config BLK_DEV_DRBD
config DRBD_TRACE
tristate "DRBD tracing"
depends on BLK_DEV_DRBD
+ depends on BROKEN
select TRACEPOINTS
default m
help
--
1.6.3.3
On Monday 27 July 2009 09:37:54 Stephen Rothwell wrote:
> Hi Philipp,
>
> Today's linux-next build (powerpc allyesconfig) failed like this:
>
> drivers/block/drbd/drbd_trace.o: In function `.roles_to_name':
> (.text+0x64): multiple definition of `.roles_to_name'
> drivers/block/drbd/drbd.o:(.text+0x28eb8): first defined here
> drivers/block/drbd/drbd_trace.o: In function `disks_to_name':
> (.opd+0x30): multiple definition of `disks_to_name'
> drivers/block/drbd/drbd.o:(.opd+0x1b78): first defined here
> drivers/block/drbd/drbd_trace.o: In function `roles_to_name':
> (.opd+0x18): multiple definition of `roles_to_name'
> drivers/block/drbd/drbd.o:(.opd+0x1b60): first defined here
> drivers/block/drbd/drbd_trace.o: In function `.conns_to_name':
> (.text+0x0): multiple definition of `.conns_to_name'
> drivers/block/drbd/drbd.o:(.text+0x28e54): first defined here
> drivers/block/drbd/drbd_trace.o: In function `set_st_err_name':
> (.opd+0x48): multiple definition of `set_st_err_name'
> drivers/block/drbd/drbd.o:(.opd+0x1b90): first defined here
> drivers/block/drbd/drbd_trace.o: In function `.disks_to_name':
> (.text+0xcc): multiple definition of `.disks_to_name'
> drivers/block/drbd/drbd.o:(.text+0x28f20): first defined here
> drivers/block/drbd/drbd_trace.o: In function `conns_to_name':
> (.opd+0x0): multiple definition of `conns_to_name'
> drivers/block/drbd/drbd.o:(.opd+0x1b48): first defined here
> drivers/block/drbd/drbd_trace.o: In function `.set_st_err_name':
> (.text+0x134): multiple definition of `.set_st_err_name'
> drivers/block/drbd/drbd.o:(.text+0x28f88): first defined here
>
> I applied the following patch to mark DRBD_TRACE broken for now.
I have fixed that issue. With the next pull, drbd_tracing should
compile on PPC.
BTW, we are working on making our stuff compatible with Rusty's
cpu set changes. I expect that this will be finished soon...
-Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
One more issue
drivers/block/drbd/drbd_main.c: In function 'drbd_buildtag':
drivers/block/drbd/drbd_main.c:3738: error: dereferencing pointer to
incomplete type
On Monday 27 July 2009 13:38:44 Alexander Beregalov wrote:
> One more issue
>
> drivers/block/drbd/drbd_main.c: In function 'drbd_buildtag':
> drivers/block/drbd/drbd_main.c:3738: error: dereferencing pointer to
> incomplete type
Ohh, right. I have never tried to build a kernel with the DRBD patch
without CONFIG_MODULES set.
It is fixed now.
-Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
Hi Philipp,
On Mon, 27 Jul 2009 17:07:58 +0200 Philipp Reisner <[email protected]> wrote:
>
> On Monday 27 July 2009 13:38:44 Alexander Beregalov wrote:
> > One more issue
> >
> > drivers/block/drbd/drbd_main.c: In function 'drbd_buildtag':
> > drivers/block/drbd/drbd_main.c:3738: error: dereferencing pointer to
> > incomplete type
>
> Ohh, right. I have never tried to build a kernel with the DRBD patch
> without CONFIG_MODULES set.
>
> It is fixed now.
Thanks.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Philipp,
On Mon, 27 Jul 2009 11:09:32 +0200 Philipp Reisner <[email protected]> wrote:
>
> On Monday 27 July 2009 09:37:54 Stephen Rothwell wrote:
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> >
> > drivers/block/drbd/drbd_trace.o: In function `.roles_to_name':
> > (.text+0x64): multiple definition of `.roles_to_name'
> > drivers/block/drbd/drbd.o:(.text+0x28eb8): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `disks_to_name':
> > (.opd+0x30): multiple definition of `disks_to_name'
> > drivers/block/drbd/drbd.o:(.opd+0x1b78): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `roles_to_name':
> > (.opd+0x18): multiple definition of `roles_to_name'
> > drivers/block/drbd/drbd.o:(.opd+0x1b60): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `.conns_to_name':
> > (.text+0x0): multiple definition of `.conns_to_name'
> > drivers/block/drbd/drbd.o:(.text+0x28e54): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `set_st_err_name':
> > (.opd+0x48): multiple definition of `set_st_err_name'
> > drivers/block/drbd/drbd.o:(.opd+0x1b90): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `.disks_to_name':
> > (.text+0xcc): multiple definition of `.disks_to_name'
> > drivers/block/drbd/drbd.o:(.text+0x28f20): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `conns_to_name':
> > (.opd+0x0): multiple definition of `conns_to_name'
> > drivers/block/drbd/drbd.o:(.opd+0x1b48): first defined here
> > drivers/block/drbd/drbd_trace.o: In function `.set_st_err_name':
> > (.text+0x134): multiple definition of `.set_st_err_name'
> > drivers/block/drbd/drbd.o:(.text+0x28f88): first defined here
> >
> > I applied the following patch to mark DRBD_TRACE broken for now.
>
> I have fixed that issue. With the next pull, drbd_tracing should
> compile on PPC.
Thanks.
> BTW, we are working on making our stuff compatible with Rusty's
> cpu set changes. I expect that this will be finished soon...
Excellent.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/