2009-09-10 23:58:00

by David Daney

Subject: [PATCH 04/10] s390: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;);

Signed-off-by: David Daney <[email protected]>
CC: Martin Schwidefsky <[email protected]>
CC: Heiko Carstens <[email protected]>
CC: [email protected]
CC: [email protected]
---
arch/s390/include/asm/bug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
index 7efd0ab..efb74fd 100644
--- a/arch/s390/include/asm/bug.h
+++ b/arch/s390/include/asm/bug.h
@@ -49,7 +49,7 @@

#define BUG() do { \
__EMIT_BUG(0); \
- for (;;); \
+ unreachable(); \
} while (0)

#define WARN_ON(x) ({ \
--
1.6.2.5

2009-09-11 12:18:26

by Martin Schwidefsky

Subject: Re: [PATCH 04/10] s390: Convert BUG() to use unreachable()

On Thu, 10 Sep 2009 16:56:45 -0700
David Daney <[email protected]> wrote:

> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: David Daney <[email protected]>
> CC: Martin Schwidefsky <[email protected]>
> CC: Heiko Carstens <[email protected]>
> CC: [email protected]
> CC: [email protected]
> ---
> arch/s390/include/asm/bug.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/s390/include/asm/bug.h b/arch/s390/include/asm/bug.h
> index 7efd0ab..efb74fd 100644
> --- a/arch/s390/include/asm/bug.h
> +++ b/arch/s390/include/asm/bug.h
> @@ -49,7 +49,7 @@
>
> #define BUG() do { \
> __EMIT_BUG(0); \
> - for (;;); \
> + unreachable(); \
> } while (0)
>
> #define WARN_ON(x) ({ \

That seems simple enough ;-)

Acked-by: Martin Schwidefsky <[email protected]>

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.