2009-10-09 14:14:47

by Miguel Boton

[permalink] [raw]
Subject: [PATCH] b43: add 'struct b43_wl' missing declaration

'struct b43_wl' declaration is missing at 'leds.h'.
It should be declared to avoid getting some GCC warnings at 'b43_leds_unregister'.

Signed-off-by: Miguel Botón <[email protected]>

---

drivers/net/wireless/b43/leds.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/b43/leds.h b/drivers/net/wireless/b43/leds.h
index 4c56187..32b66d5 100644
--- a/drivers/net/wireless/b43/leds.h
+++ b/drivers/net/wireless/b43/leds.h
@@ -1,6 +1,7 @@
#ifndef B43_LEDS_H_
#define B43_LEDS_H_

+struct b43_wl;
struct b43_wldev;

#ifdef CONFIG_B43_LEDS


2009-10-09 14:30:34

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] b43: add 'struct b43_wl' missing declaration

On Friday 09 October 2009 16:13:53 Miguel Boton wrote:
> 'struct b43_wl' declaration is missing at 'leds.h'.
> It should be declared to avoid getting some GCC warnings at 'b43_leds_unregister'.
>
> Signed-off-by: Miguel Botón <[email protected]>

ack
(That was fast enough, eh? :D)

>
> ---
>
> drivers/net/wireless/b43/leds.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/leds.h b/drivers/net/wireless/b43/leds.h
> index 4c56187..32b66d5 100644
> --- a/drivers/net/wireless/b43/leds.h
> +++ b/drivers/net/wireless/b43/leds.h
> @@ -1,6 +1,7 @@
> #ifndef B43_LEDS_H_
> #define B43_LEDS_H_
>
> +struct b43_wl;
> struct b43_wldev;
>
> #ifdef CONFIG_B43_LEDS
>
>



--
Greetings, Michael.

2009-10-09 14:36:49

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] b43: add 'struct b43_wl' missing declaration

On 10/09/2009 09:13 AM, Miguel Boton wrote:
> 'struct b43_wl' declaration is missing at 'leds.h'.
> It should be declared to avoid getting some GCC warnings at 'b43_leds_unregister'.
>
> Signed-off-by: Miguel Botón <[email protected]>

What architecture? There must be something strange with your
configuration as I see no such warnings. Please post your .CONFIG.

Larry