2009-11-02 16:52:27

by Ben Dooks

Subject: tps65010: Allow the board to choose any GPIO base.

If the board does not care where the TPS turns up, then specifiying the
value -1 to get gpiolib to dynamically allocate the base for the chip
is valid.

Change the test to look for != 0, so that any boards specifying zero
will not end up with gpio that they didn't want.

Signed-off-by: Ben Dooks <[email protected]>
Signed-off-by: Simtec Liunx Team <[email protected]>

---
drivers/mfd/tps65010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/mfd/tps65010.c
===================================================================
--- a/drivers/mfd/tps65010.c 2009-10-21 19:09:28.000000000 +0100
+++ b/drivers/mfd/tps65010.c 2009-10-21 19:09:39.000000000 +0100
@@ -637,7 +637,7 @@ static int tps65010_probe(struct i2c_cli
tps, DEBUG_FOPS);

/* optionally register GPIOs */
- if (board && board->base > 0) {
+ if (board && board->base != 0) {
tps->outmask = board->outmask;

tps->chip.label = client->name;

--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'

2009-11-04 11:42:04

by Samuel Ortiz

Subject: Re: tps65010: Allow the board to choose any GPIO base.

Hi Ben,

On Mon, Nov 02, 2009 at 04:52:20PM +0000, Ben Dooks wrote:
> If the board does not care where the TPS turns up, then specifiying the
> value -1 to get gpiolib to dynamically allocate the base for the chip
> is valid.
>
> Change the test to look for != 0, so that any boards specifying zero
> will not end up with gpio that they didn't want.
>
> Signed-off-by: Ben Dooks <[email protected]>
> Signed-off-by: Simtec Liunx Team <[email protected]>
Applied, thanks a lot.


> ---
> drivers/mfd/tps65010.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/mfd/tps65010.c
> ===================================================================
> --- a/drivers/mfd/tps65010.c 2009-10-21 19:09:28.000000000 +0100
> +++ b/drivers/mfd/tps65010.c 2009-10-21 19:09:39.000000000 +0100
> @@ -637,7 +637,7 @@ static int tps65010_probe(struct i2c_cli
> tps, DEBUG_FOPS);
>
> /* optionally register GPIOs */
> - if (board && board->base > 0) {
> + if (board && board->base != 0) {
> tps->outmask = board->outmask;
>
> tps->chip.label = client->name;
>
> --
> Ben ([email protected], http://www.fluff.org/)
>
> 'a smiley only costs 4 bytes'

--
Intel Open Source Technology Centre
http://oss.intel.com/