2009-12-17 02:13:50

by Pavel Vasilyev

[permalink] [raw]
Subject: HTC Dream camera, not need sizeof

http://bugzilla.kernel.org/show_bug.cgi?id=14825


On line 258, sizeof(extlen), always will be sizeof( unit32_t) or 4

It seems that something is wrong?!?! :)


Original

255 extlen = sizeof(struct vfe_frame_extra);
256
257 extdata =
258 kmalloc(sizeof(extlen), GFP_ATOMIC);

is equal kmalloc(sizeof(uint32_t), GFP_ATOMIC);
But then do not need to calculate the size of the structure -
sizeof(vfe_frame_extra) ???

259 if (!extdata) {
260 rc = -ENOMEM;
261 goto init_fail;

---------------------
May be next?


diff --git a/drivers/staging/dream/camera/msm_vfe7x.c
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
extlen = sizeof(struct vfe_frame_extra);

extdata =
- kmalloc(sizeof(extlen), GFP_ATOMIC);
+ kmalloc(extlen, GFP_ATOMIC);
if (!extdata) {
rc = -ENOMEM;
goto init_fail;