2010-01-08 18:30:47

by Hartley Sweeten

Subject: [PATCH] cm4000_cs.c: Remove unnecessary cast

cm4000_cs.c: Remove unnecessary cast

The struct file 'private_data' member is a void *, the cast is not needed.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Harald Welte <[email protected]>

---

diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
index 2db4c0a..c9bc896 100644
--- a/drivers/char/pcmcia/cm4000_cs.c
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -1047,7 +1047,7 @@ release_io:
static ssize_t cmm_write(struct file *filp, const char __user *buf,
size_t count, loff_t *ppos)
{
- struct cm4000_dev *dev = (struct cm4000_dev *) filp->private_data;
+ struct cm4000_dev *dev = filp->private_data;
unsigned int iobase = dev->p_dev->io.BasePort1;
unsigned short s;
unsigned char tmp;

2010-01-09 12:38:20

by Dominik Brodowski

Subject: Re: [PATCH] cm4000_cs.c: Remove unnecessary cast

Hey,

On Fri, Jan 08, 2010 at 11:30:13AM -0700, H Hartley Sweeten wrote:
> cm4000_cs.c: Remove unnecessary cast
>
> The struct file 'private_data' member is a void *, the cast is not needed.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Harald Welte <[email protected]>

Applied to linux-pcmcia, in queue for 2.6.34-rc1.

Thanks,
Dominik