2010-02-10 23:32:49

by Jiri Slaby

Subject: [PATCH 1/1] DVB: ngene, fix memset parameters

Switch second and third memset parameter to stamp the length buffer bytes
by 0xff's, not 255 bytes by low 8 bits of Length.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Matthias Benesch <[email protected]>
Cc: Ralph Metzler <[email protected]>
Cc: Oliver Endriss <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
---
drivers/media/dvb/ngene/ngene-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index cb5982e..0150dfe 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
{
u32 *ptr = Buffer;

- memset(Buffer, Length, 0xff);
+ memset(Buffer, 0xff, Length);
while (Length > 0) {
if (Flags & DF_SWAP32)
*ptr = 0x471FFF10;
--
1.6.6.1

2010-02-11 04:32:35

by Oliver Endriss

Subject: Re: [PATCH 1/1] DVB: ngene, fix memset parameters

Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Matthias Benesch <[email protected]>
> Cc: Ralph Metzler <[email protected]>
> Cc: Oliver Endriss <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> ---
> drivers/media/dvb/ngene/ngene-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
> {
> u32 *ptr = Buffer;
>
> - memset(Buffer, Length, 0xff);
> + memset(Buffer, 0xff, Length);
> while (Length > 0) {
> if (Flags & DF_SWAP32)
> *ptr = 0x471FFF10;
> --
> 1.6.6.1

Acked-by: Oliver Endriss <[email protected]>

CU
Oliver

--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------