2010-02-21 14:23:30

by Dave Young

[permalink] [raw]
Subject: [PATCH -mm 04/17] sysctl extern cleanup - pid

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move pid/pid_max_min/pid_max_max extern declarations to linux/pid.h

Signed-off-by: Dave Young <[email protected]>
---
include/linux/pid.h | 4 ++++
kernel/sysctl.c | 3 +--
2 files changed, 5 insertions(+), 2 deletions(-)

--- linux-2.6.32.orig/include/linux/pid.h 2010-02-21 09:35:58.494024120 +0800
+++ linux-2.6.32/include/linux/pid.h 2010-02-21 09:47:29.753122891 +0800
@@ -3,6 +3,10 @@

#include <linux/rcupdate.h>

+/* for sysctl */
+extern int pid_max;
+extern int pid_max_min, pid_max_max;
+
enum pid_type
{
PIDTYPE_PID,
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:44:39.479806692 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 09:48:06.843951983 +0800
@@ -56,6 +56,7 @@
#include <linux/rcustring.h>
#include <linux/signal.h>
#include <linux/binfmts.h>
+#include <linux/pid.h>

#include <asm/uaccess.h>
#include <asm/processor.h>
@@ -71,9 +72,7 @@

/* External variables not in a header file. */
extern int max_threads;
-extern int pid_max;
extern int min_free_kbytes;
-extern int pid_max_min, pid_max_max;
extern int compat_log;
extern int latencytop_enabled;
extern int sysctl_nr_open_min, sysctl_nr_open_max;