2010-06-02 06:51:35

by Thomas Weber

Subject: [PATCH] Input: ads7846: Fix warning about output format

This patch fixes a compiler warning about wrong output format.

drivers/input/touchscreen/ads7846.c: In function 'ads7846_probe':
drivers/input/touchscreen/ads7846.c:1167: warning: format '%ld' expects
type 'long int', but argument 4 has type 'int'

Introduced by commit 067fb2f648543894ce775082c5636f4c32b99e4f ("Input:
ads7846 - return error on regulator_get() failure").

The ERR_PTR returns a long so the variable err needs to be long.

Signed-off-by: Thomas Weber <[email protected]>
---
drivers/input/touchscreen/ads7846.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 634f6f6..9ba7d2e 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -885,7 +885,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
struct spi_message *m;
struct spi_transfer *x;
int vref;
- int err;
+ long err;

if (!spi->irq) {
dev_dbg(&spi->dev, "no IRQ?\n");
@@ -1170,7 +1170,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)

err = regulator_enable(ts->reg);
if (err) {
- dev_err(&spi->dev, "unable to enable regulator: %d\n", err);
+ dev_err(&spi->dev, "unable to enable regulator: %ld\n", err);
goto err_put_regulator;
}

--
1.7.1

2010-06-02 07:40:04

by Dmitry Torokhov

Subject: Re: [PATCH] Input: ads7846: Fix warning about output format

On Wed, Jun 02, 2010 at 08:50:29AM +0200, Thomas Weber wrote:
> This patch fixes a compiler warning about wrong output format.
>
> drivers/input/touchscreen/ads7846.c: In function 'ads7846_probe':
> drivers/input/touchscreen/ads7846.c:1167: warning: format '%ld' expects
> type 'long int', but argument 4 has type 'int'
>
> Introduced by commit 067fb2f648543894ce775082c5636f4c32b99e4f ("Input:
> ads7846 - return error on regulator_get() failure").
>
> The ERR_PTR returns a long so the variable err needs to be long.

No, int works just as well. I have a patch that simply fixes format
specification.

Thanks.

--
Dmitry