2010-06-03 13:50:33

by Stephane Eranian

[permalink] [raw]
Subject: [PATCH] perf: make annotate demangle symbols

Perf report is demangling symbols but not annotate.
The former uses internal demangling via libbdf or
libiberty. The latter executes objdump which by default
does not demangle symbols.

This patch adds the -C option to the objdump cmdline
to enable symbol demangling.

Signed-off-by: Stephane Eranian <[email protected]>

diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 07f89b6..9e6baad 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1037,7 +1037,7 @@ fallback:
dso, dso->long_name, sym, sym->name);

snprintf(command, sizeof(command),
- "objdump --start-address=0x%016Lx --stop-address=0x%016Lx -dS %s|grep -v %s|expand",
+ "objdump --start-address=0x%016Lx --stop-address=0x%016Lx -dS -C %s|grep -v %s|expand",
map__rip_2objdump(map, sym->start),
map__rip_2objdump(map, sym->end),
filename, filename);


2010-06-04 02:16:12

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH] perf: make annotate demangle symbols

Em Thu, Jun 03, 2010 at 03:50:01PM +0200, Stephane Eranian escreveu:
> Perf report is demangling symbols but not annotate.
> The former uses internal demangling via libbdf or
> libiberty. The latter executes objdump which by default
> does not demangle symbols.
>
> This patch adds the -C option to the objdump cmdline
> to enable symbol demangling.
>
> Signed-off-by: Stephane Eranian <[email protected]>

Thanks, Applied.

- Arnaldo