2010-06-24 09:06:12

by Wan ZongShun

Subject: [PATCH 3/3] RTC/nuc900: fix build warning

Firstly,I am sorry for this patch, because I omit the warning
when I submit 'nuc900-rtc-change-the-waiting-for-device-ready-implement.patch'.
so I have to send a patch to fix it.

It is reported by Nuvoton test guys, thanks.

Signed-off-by: Wan ZongShun <[email protected]>

---
drivers/rtc/rtc-nuc900.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
index 0267ea3..62de66a 100644
--- a/drivers/rtc/rtc-nuc900.c
+++ b/drivers/rtc/rtc-nuc900.c
@@ -85,7 +85,7 @@ static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc)

static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
{
- unsigned int i, timeout = 0x1000;
+ unsigned int timeout = 0x1000;
__raw_writel(INIRRESET, nuc900_rtc->rtc_reg + REG_RTC_INIR);

mdelay(10);
--
1.6.3.3

2010-06-30 19:43:22

by Andrew Morton

Subject: Re: [PATCH 3/3] RTC/nuc900: fix build warning

On Thu, 24 Jun 2010 17:05:57 +0800
Wan ZongShun <[email protected]> wrote:

> Firstly,I am sorry for this patch, because I omit the warning
> when I submit 'nuc900-rtc-change-the-waiting-for-device-ready-implement.patch'.
> so I have to send a patch to fix it.

When fixing a warning or build error, pelase quote the compiler
messages in the changelog so we can see what got fixed.

> It is reported by Nuvoton test guys, thanks.

I don't know who that is. Perhaps use the Reported-by: tag here?

> Signed-off-by: Wan ZongShun <[email protected]>
>
> ---
> drivers/rtc/rtc-nuc900.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
> index 0267ea3..62de66a 100644
> --- a/drivers/rtc/rtc-nuc900.c
> +++ b/drivers/rtc/rtc-nuc900.c
> @@ -85,7 +85,7 @@ static irqreturn_t nuc900_rtc_interrupt(int irq, void *_rtc)
>
> static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
> {
> - unsigned int i, timeout = 0x1000;
> + unsigned int timeout = 0x1000;
> __raw_writel(INIRRESET, nuc900_rtc->rtc_reg + REG_RTC_INIR);

Well it's pretty obvious what the warning was this time.