2010-06-28 20:29:46

by Przemo Firszt

Subject: [PATCH] Expose vendor-specific ACM channel on Nokia 5230

Nokia S60 phones expose two ACM channels. The first is
a modem, the second is 'vendor-specific' but is treated
as a serial device at the S60 end, so we want to expose
it on Linux too.

Signed-off-by: Przemo Firszt <[email protected]>
---
drivers/usb/class/cdc-acm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 61d7550..162c95a 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1596,6 +1596,7 @@ static const struct usb_device_id acm_ids[] = {
{ NOKIA_PCSUITE_ACM_INFO(0x00e9), }, /* Nokia 5320 XpressMusic */
{ NOKIA_PCSUITE_ACM_INFO(0x0108), }, /* Nokia 5320 XpressMusic 2G */
{ NOKIA_PCSUITE_ACM_INFO(0x01f5), }, /* Nokia N97, RM-505 */
+ { NOKIA_PCSUITE_ACM_INFO(0x02e3), }, /* Nokia 5230, RM-588 */

/* NOTE: non-Nokia COMM/ACM/0xff is likely MSFT RNDIS... NOT a modem! */

--
1.7.1

2010-06-28 20:59:51

by Oliver Neukum

Subject: Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230

Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> Nokia S60 phones expose two ACM channels. The first is
> a modem, the second is 'vendor-specific' but is treated
> as a serial device at the S60 end, so we want to expose
> it on Linux too.
>

I see. We want to expose it. But do we want to expose it as an acm interface?

Regards
Oliver

2010-06-29 17:43:36

by Przemo Firszt

Subject: Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230

Dnia 2010-06-28, pon o godzinie 22:59 +0200, Oliver Neukum pisze:
> Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> > Nokia S60 phones expose two ACM channels. The first is
> > a modem, the second is 'vendor-specific' but is treated
> > as a serial device at the S60 end, so we want to expose
> > it on Linux too.
> >
>
> I see. We want to expose it. But do we want to expose it as an acm interface?
>
> Regards
> Oliver
It's just continuation of [1]. I don't feel pressure to do it that way
if there are any better ideas.

[1] http://article.gmane.org/gmane.linux.kernel.commits.head/221222
--
Kind regards,
Przemo Firszt

2010-06-30 13:44:21

by Oliver Neukum

Subject: Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230

Am Dienstag, 29. Juni 2010, 19:43:23 schrieb Przemo Firszt:
> Dnia 2010-06-28, pon o godzinie 22:59 +0200, Oliver Neukum pisze:
> > Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> > > Nokia S60 phones expose two ACM channels. The first is
> > > a modem, the second is 'vendor-specific' but is treated
> > > as a serial device at the S60 end, so we want to expose
> > > it on Linux too.
> > >
> >
> > I see. We want to expose it. But do we want to expose it as an acm interface?
> >
> > Regards
> > Oliver
> It's just continuation of [1]. I don't feel pressure to do it that way
> if there are any better ideas.

I see. Let's do it.

Regards
Oliver