2010-06-29 12:31:25

by Kulikov Vasiliy

Subject: [PATCH] Documentation: fix ubuntu distro name

10.04 is Lucid, not Karmic.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
Documentation/coccinelle.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
index ba3315d..cd2b028 100644
--- a/Documentation/coccinelle.txt
+++ b/Documentation/coccinelle.txt
@@ -14,7 +14,7 @@ of many distributions, e.g. :

- Debian (>=squeeze)
- Fedora (>=13)
- - Ubuntu (>=10.04 Karmic Koala)
+ - Ubuntu (>=10.04 Lucid Lynx)
- OpenSUSE
- Arch Linux
- NetBSD
--
1.7.0.4

2010-06-29 12:47:24

by Nicolas Palix

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

Hi Kulikov,

Indeed. I mixed things.

But Coccinelle was already in Karmic [1].
Can you submit a patch with 9.10 instead of 10.04 ?

I will Ack it.

Thanks.

[1] https://launchpad.net/ubuntu/+source/coccinelle

On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:
> 10.04 is Lucid, not Karmic.


>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> Documentation/coccinelle.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
> index ba3315d..cd2b028 100644
> --- a/Documentation/coccinelle.txt
> +++ b/Documentation/coccinelle.txt
> @@ -14,7 +14,7 @@ of many distributions, e.g. :
>
> - Debian (>=squeeze)
> - Fedora (>=13)
> - - Ubuntu (>=10.04 Karmic Koala)
> + - Ubuntu (>=10.04 Lucid Lynx)
> - OpenSUSE
> - Arch Linux
> - NetBSD
>

--
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/

2010-06-29 12:57:21

by Nicolas Palix

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

The version in Karmic is too old. The right correction is indeed Lucid Lynx.

On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:
> 10.04 is Lucid, not Karmic.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> Documentation/coccinelle.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
> index ba3315d..cd2b028 100644
> --- a/Documentation/coccinelle.txt
> +++ b/Documentation/coccinelle.txt
> @@ -14,7 +14,7 @@ of many distributions, e.g. :
>
> - Debian (>=squeeze)
> - Fedora (>=13)
> - - Ubuntu (>=10.04 Karmic Koala)
> + - Ubuntu (>=10.04 Lucid Lynx)
> - OpenSUSE
> - Arch Linux
> - NetBSD
>

Acked-by: Nicolas Palix <[email protected]>

--
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/

2010-06-29 12:59:07

by Kulikov Vasiliy

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

On Tue, Jun 29, 2010 at 14:47 +0200, Nicolas Palix wrote:
> Hi Kulikov,
>
> Indeed. I mixed things.
>
> But Coccinelle was already in Karmic [1].
> Can you submit a patch with 9.10 instead of 10.04 ?
>
> I will Ack it.
>
> Thanks.
>
> [1] https://launchpad.net/ubuntu/+source/coccinelle

As you see in [1], coccinelle version in Karmic is 0.1.9.
I don't know if it is buggy for linux.

In documentation it is 0.2.0:
> Coccinelle (>=0.2.0) is available through the package manager
> of many distributions, e.g. :
>
> - Debian (>=squeeze)
> - Fedora (>=13)
> - Ubuntu (>=10.04 Lucid Lynx)
> - OpenSUSE
> - Arch Linux
> - NetBSD
> - FreeBSD

So, if 0.1.9 is OK, I can make smth like this:
> - Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

2010-06-29 13:01:18

by Jiri Kosina

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

On Tue, 29 Jun 2010, Kulikov Vasiliy wrote:

> > Indeed. I mixed things.
> >
> > But Coccinelle was already in Karmic [1].
> > Can you submit a patch with 9.10 instead of 10.04 ?
> >
> > I will Ack it.
> >
> > Thanks.
> >
> > [1] https://launchpad.net/ubuntu/+source/coccinelle
>
> As you see in [1], coccinelle version in Karmic is 0.1.9.
> I don't know if it is buggy for linux.
>
> In documentation it is 0.2.0:
> > Coccinelle (>=0.2.0) is available through the package manager
> > of many distributions, e.g. :
> >
> > - Debian (>=squeeze)
> > - Fedora (>=13)
> > - Ubuntu (>=10.04 Lucid Lynx)
> > - OpenSUSE
> > - Arch Linux
> > - NetBSD
> > - FreeBSD
>
> So, if 0.1.9 is OK, I can make smth like this:
> > - Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)

Do we really want all this in kernel documentation in the first place?

--
Jiri Kosina
SUSE Labs, Novell Inc.

2010-06-29 13:19:26

by Nicolas Palix

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

On Tuesday 29 June 2010 14:59:01 Kulikov Vasiliy wrote:
> On Tue, Jun 29, 2010 at 14:47 +0200, Nicolas Palix wrote:
> > Hi Kulikov,
> >
> > Indeed. I mixed things.
> >
> > But Coccinelle was already in Karmic [1].
> > Can you submit a patch with 9.10 instead of 10.04 ?
> >
> > I will Ack it.
> >
> > Thanks.
> >
> > [1] https://launchpad.net/ubuntu/+source/coccinelle
>
> As you see in [1], coccinelle version in Karmic is 0.1.9.
> I don't know if it is buggy for linux.
>
> In documentation it is 0.2.0:
> > Coccinelle (>=0.2.0) is available through the package manager
> > of many distributions, e.g. :
> >
> > - Debian (>=squeeze)
> > - Fedora (>=13)
> > - Ubuntu (>=10.04 Lucid Lynx)
> > - OpenSUSE
> > - Arch Linux
> > - NetBSD
> > - FreeBSD
>
> So, if 0.1.9 is OK, I can make smth like this:
> > - Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)
>

I figured out that point later, and sent a Acked-by for your original patch.
I think our mails have crossed each other.

Indeed, the version 0.1.9 does not provide the virtual rule feature, which is required
for the coccinelle files we have submitted.

--
Nicolas Palix
Web: http://www.diku.dk/~npalix/

2010-06-29 13:28:10

by Michal Marek

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

On 29.6.2010 14:57, Nicolas Palix wrote:
>
> The version in Karmic is too old. The right correction is indeed Lucid Lynx.
>
> On Tuesday 29 June 2010 14:31:16 Kulikov Vasiliy wrote:
>> 10.04 is Lucid, not Karmic.
>>
>> Signed-off-by: Kulikov Vasiliy <[email protected]>
>> ---
>> Documentation/coccinelle.txt | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/coccinelle.txt b/Documentation/coccinelle.txt
>> index ba3315d..cd2b028 100644
>> --- a/Documentation/coccinelle.txt
>> +++ b/Documentation/coccinelle.txt
>> @@ -14,7 +14,7 @@ of many distributions, e.g. :
>>
>> - Debian (>=squeeze)
>> - Fedora (>=13)
>> - - Ubuntu (>=10.04 Karmic Koala)
>> + - Ubuntu (>=10.04 Lucid Lynx)
>> - OpenSUSE
>> - Arch Linux
>> - NetBSD
>>
>
> Acked-by: Nicolas Palix <[email protected]>

Applied.

Michal

2010-06-29 13:36:33

by Nicolas Palix

Subject: Re: [PATCH] Documentation: fix ubuntu distro name

On Tuesday 29 June 2010 15:01:14 Jiri Kosina wrote:
> On Tue, 29 Jun 2010, Kulikov Vasiliy wrote:
>
> > > Indeed. I mixed things.
> > >
> > > But Coccinelle was already in Karmic [1].
> > > Can you submit a patch with 9.10 instead of 10.04 ?
> > >
> > > I will Ack it.
> > >
> > > Thanks.
> > >
> > > [1] https://launchpad.net/ubuntu/+source/coccinelle
> >
> > As you see in [1], coccinelle version in Karmic is 0.1.9.
> > I don't know if it is buggy for linux.
> >
> > In documentation it is 0.2.0:
> > > Coccinelle (>=0.2.0) is available through the package manager
> > > of many distributions, e.g. :
> > >
> > > - Debian (>=squeeze)
> > > - Fedora (>=13)
> > > - Ubuntu (>=10.04 Lucid Lynx)
> > > - OpenSUSE
> > > - Arch Linux
> > > - NetBSD
> > > - FreeBSD
> >
> > So, if 0.1.9 is OK, I can make smth like this:
> > > - Ubuntu (>=9.04 Karmic Koala, coccinelle = 0.1.9)
>
> Do we really want all this in kernel documentation in the first place?
>

It addresses a comment [1] I got during the review process.

[1] http://lkml.org/lkml/2010/5/10/316

>

--
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/