2010-07-09 07:41:58

by Thomas Weber

Subject: [PATCH] OMAP2: powerdomain: Add break in switch statement

Add a missing break at end of switch statement. At the moment it is a
fall through to WARN_ON(1) and return -EEXIST.

Signed-off-by: Thomas Weber <[email protected]>
---
arch/arm/mach-omap2/powerdomain.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index a2904aa..6527ec3 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -875,6 +875,7 @@ int pwrdm_read_mem_retst(struct powerdomain *pwrdm, u8 bank)
break;
case 4:
m = OMAP_MEM4_RETSTATE_MASK;
+ break;
default:
WARN_ON(1); /* should never happen */
return -EEXIST;
--
1.7.1

2010-07-12 20:21:07

by Paul Walmsley

Subject: Re: [PATCH] OMAP2: powerdomain: Add break in switch statement

On Fri, 9 Jul 2010, Thomas Weber wrote:

> Add a missing break at end of switch statement. At the moment it is a
> fall through to WARN_ON(1) and return -EEXIST.
>
> Signed-off-by: Thomas Weber <[email protected]>

Thanks Thomas.

Tony, this is

Acked-by: Paul Walmsley <[email protected]>

if you want it for .36; otherwise, can queue it for .37 here.


- Paul

2010-08-03 07:21:56

by Tony Lindgren

Subject: Re: [PATCH] OMAP2: powerdomain: Add break in switch statement

* Paul Walmsley <[email protected]> [100712 23:14]:
> On Fri, 9 Jul 2010, Thomas Weber wrote:
>
> > Add a missing break at end of switch statement. At the moment it is a
> > fall through to WARN_ON(1) and return -EEXIST.
> >
> > Signed-off-by: Thomas Weber <[email protected]>
>
> Thanks Thomas.
>
> Tony, this is
>
> Acked-by: Paul Walmsley <[email protected]>
>
> if you want it for .36; otherwise, can queue it for .37 here.

Thanks, I've added it into omap-for-linus.

Regards,

Tony