Dave,
Please find attached a patch that fixes a boot time regression caused by
commit f1befe71fa7a79ab733011b045639d8d809924ad. It has been reported to
fix at least one user's boot problems.
I think it is also likely the source of the problems reported in
http://marc.info/?l=linux-kernel&m=127869783002454&w=2
rtg
--
Tim Gardner [email protected]
On Fri, Jul 9, 2010 at 4:48 PM, Tim Gardner <[email protected]> wrote:
>
> Dave,
>
> Please find attached a patch that fixes a boot time regression caused by commit f1befe71fa7a79ab733011b045639d8d809924ad. It has been reported to fix at least one user's boot problems.
>
> I think it is also likely the source of the problems reported in http://marc.info/?l=linux-kernel&m=127869783002454&w=2
>
> rtg
> --
> Tim Gardner [email protected]
Jesse, the above patch
0001-UBUNTU-Upstream-i915-Use-the-correct-mask-to-detect-.patch
is fixing my problem as well. No need for bisecting...
Thanks, Woody
PS. I am sending from GMail Web client - strange things (e.g .HTML)
may happen ;-(
Dave,
http://lkml.org/lkml/2010/7/9/287
What's up with this patch? I haven't received any comment, nor has it
appeared in your git repository.
rtg
--
Tim Gardner [email protected]
On Wed, 21 Jul 2010 14:35:22 +0200, Tim Gardner <[email protected]> wrote:
> What's up with this patch? I haven't received any comment, nor has it
> appeared in your git repository.
Dave hasn't taken it because it is a regression fix for i915 and the
current procedure is for those to go through Eric's tree. Eric has been
busy working on a new compiler for GLSL the last few weeks and has been
applying patches in batches.
The patch I am happy to ack, but since I introduced the regression
[https://bugzilla.kernel.org/show_bug.cgi?id=16294], I'd rather have
someone more familiar with the intricacies of G33/G35/Q35 review it.
For what is worth:
Acked-by: Chris Wilson <[email protected]>
--
Chris Wilson, Intel Open Source Technology Centre
On 07/21/2010 03:37 PM, Chris Wilson wrote:
> On Wed, 21 Jul 2010 14:35:22 +0200, Tim Gardner<[email protected]> wrote:
>> What's up with this patch? I haven't received any comment, nor has it
>> appeared in your git repository.
>
> Dave hasn't taken it because it is a regression fix for i915 and the
> current procedure is for those to go through Eric's tree. Eric has been
> busy working on a new compiler for GLSL the last few weeks and has been
> applying patches in batches.
>
> The patch I am happy to ack, but since I introduced the regression
> [https://bugzilla.kernel.org/show_bug.cgi?id=16294], I'd rather have
> someone more familiar with the intricacies of G33/G35/Q35 review it.
>
> For what is worth:
> Acked-by: Chris Wilson<[email protected]>
>
The events that reminded me to look up the status of this patch were the
i915 regression fixes that recently appeared in
[email protected] from Dave's tree (which appears to be
contrary to the current procedure mentioned above).
rtg
--
Tim Gardner [email protected]
On Wed, 2010-07-21 at 14:35 +0200, Tim Gardner wrote:
> Dave,
>
> http://lkml.org/lkml/2010/7/9/287
>
> What's up with this patch? I haven't received any comment, nor has it
> appeared in your git repository.
I don't deal with Intel patches directly, Eric?
Dave.
Chris Wilson wrote on Wednesday, July 21, 2010 9:37 PM:
> On Wed, 21 Jul 2010 14:35:22 +0200, Tim Gardner <[email protected]>
> wrote:
>> What's up with this patch? I haven't received any comment, nor has it
>> appeared in your git repository.
>
> Dave hasn't taken it because it is a regression fix for i915 and the
> current procedure is for those to go through Eric's tree. Eric has
> been busy working on a new compiler for GLSL the last few weeks and
> has been applying patches in batches.
>
> The patch I am happy to ack, but since I introduced the regression
> [https://bugzilla.kernel.org/show_bug.cgi?id=16294], I'd rather have
> someone more familiar with the intricacies of G33/G35/Q35 review it.
>
> For what is worth:
> Acked-by: Chris Wilson <[email protected]>
This patch fixes the bug on our G33 (0x29b2).
Tested-by: Xudong Hao <[email protected]>
-Gordon-
On 07/22/2010 11:19 AM, Jin, Gordon wrote:
> Chris Wilson wrote on Wednesday, July 21, 2010 9:37 PM:
>> On Wed, 21 Jul 2010 14:35:22 +0200, Tim Gardner <[email protected]>
>> wrote:
>>> What's up with this patch? I haven't received any comment, nor has it
>>> appeared in your git repository.
>>
>> Dave hasn't taken it because it is a regression fix for i915 and the
>> current procedure is for those to go through Eric's tree. Eric has
>> been busy working on a new compiler for GLSL the last few weeks and
>> has been applying patches in batches.
>>
>> The patch I am happy to ack, but since I introduced the regression
>> [https://bugzilla.kernel.org/show_bug.cgi?id=16294], I'd rather have
>> someone more familiar with the intricacies of G33/G35/Q35 review it.
>>
>> For what is worth:
>> Acked-by: Chris Wilson <[email protected]>
>
> This patch fixes the bug on our G33 (0x29b2).
FWIW works for me too.
And as this is present as of 35-rc1 upstream, this means almost 2 months
lag since the break till now. Could you guys sort this up ASAP, please?
thanks,
--
js
Jin, Gordon wrote on Thursday, July 22, 2010 5:19 PM:
> Chris Wilson wrote on Wednesday, July 21, 2010 9:37 PM:
>> On Wed, 21 Jul 2010 14:35:22 +0200, Tim Gardner <[email protected]>
>> wrote:
>>> What's up with this patch? I haven't received any comment, nor has
>>> it appeared in your git repository.
>>
>> Dave hasn't taken it because it is a regression fix for i915 and the
>> current procedure is for those to go through Eric's tree. Eric has
>> been busy working on a new compiler for GLSL the last few weeks and
>> has been applying patches in batches.
>>
>> The patch I am happy to ack, but since I introduced the regression
>> [https://bugzilla.kernel.org/show_bug.cgi?id=16294], I'd rather have
>> someone more familiar with the intricacies of G33/G35/Q35 review it.
>>
>> For what is worth:
>> Acked-by: Chris Wilson <[email protected]>
>
> This patch fixes the bug on our G33 (0x29b2).
> Tested-by: Xudong Hao <[email protected]>
Sorry, the pci id for above G33 is actually 0x29c2.
And we also validated the patch on Q35 (0x29b2):
Tested-by: Xun Fang <[email protected]>
-Gordon