2010-08-15 16:17:51

by Claudio Scordino

[permalink] [raw]
Subject: RS485: ioctls defined twice ?

Hi all,

is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined (with the same values) in both include/asm-generic/ioctls.h and arch/arm/include/asm/ioctls.h ?

The same happens also for avr32, powerpc and cris (which, however, defines a different value for TIOCSRS485).

Is it duplicated code ?

Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?

Many thanks,

Claudio


2010-08-15 15:39:24

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: RS485: ioctls defined twice ?

On Sun, Aug 15, 2010 at 04:22:13PM +0200, Claudio Scordino wrote:
> Hi all,
>
> is there any reason why ioctls TIOCGRS485 and TIOCSRS485 are defined

Please wrap your message sensibly so I can see it while replying to you.

> The same happens also for avr32, powerpc and cris (which, however, defines
>
> Is it duplicated code ?
>
> Or should these values stay in both asm/ioctls.h and asm-generic/ioctls.h ?

As an exercise to help you answer your own question, please research
how asm-generic/ioctls.h get included on an avr32, powerpc, cris or
ARM kernel build.