2010-11-03 12:59:29

by Mark Brown

Subject: [PATCH] regulator: Staticise mc13783_powermisc_rmw()

It is not used outside this driver so no need to make the symbol global.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/mc13783-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index 5e6fa47..47ea999 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
.get_voltage = mc13783_fixed_regulator_get_voltage,
};

-int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
- u32 val)
+static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
+ u32 val)
{
struct mc13783 *mc13783 = priv->mc13783;
int ret;
--
1.7.1

2010-11-03 13:50:17

by Alberto Panizzo

Subject: Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()

On mer, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Mark Brown <[email protected]>

It's OK for me, because no other functionalities than regulator's one
are influenced by the Power Misc register.

Acked-by: Alberto Panizzo <[email protected]>

> ---
> drivers/regulator/mc13783-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
> index 5e6fa47..47ea999 100644
> --- a/drivers/regulator/mc13783-regulator.c
> +++ b/drivers/regulator/mc13783-regulator.c
> @@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = {
> .get_voltage = mc13783_fixed_regulator_get_voltage,
> };
>
> -int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> - u32 val)
> +static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask,
> + u32 val)
> {
> struct mc13783 *mc13783 = priv->mc13783;
> int ret;


--
Alberto!

Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)

2010-11-03 14:17:00

by Liam Girdwood

Subject: Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw()

On Wed, 2010-11-03 at 00:08 -0400, Mark Brown wrote:
> It is not used outside this driver so no need to make the symbol global.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/mc13783-regulator.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk