2010-11-06 19:07:32

by Tracey Dent

Subject: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile

Changed Makefile to use <modules>-y instead of <modules>-objs.

Signed-off-by: Tracey Dent <[email protected]>
---
drivers/hid/Makefile | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index c335605..dad858b 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -1,7 +1,7 @@
#
# Makefile for the HID driver
#
-hid-objs := hid-core.o hid-input.o
+hid-y := hid-core.o hid-input.o

ifdef CONFIG_DEBUG_FS
hid-objs += hid-debug.o
@@ -11,18 +11,18 @@ obj-$(CONFIG_HID) += hid.o

hid-$(CONFIG_HIDRAW) += hidraw.o

-hid-logitech-objs := hid-lg.o
+hid-logitech-y := hid-lg.o
ifdef CONFIG_LOGITECH_FF
- hid-logitech-objs += hid-lgff.o
+ hid-logitech-y += hid-lgff.o
endif
ifdef CONFIG_LOGIRUMBLEPAD2_FF
- hid-logitech-objs += hid-lg2ff.o
+ hid-logitech-y += hid-lg2ff.o
endif
ifdef CONFIG_LOGIG940_FF
- hid-logitech-objs += hid-lg3ff.o
+ hid-logitech-y += hid-lg3ff.o
endif
ifdef CONFIG_LOGIWII_FF
- hid-logitech-objs += hid-lg4ff.o
+ hid-logitech-y += hid-lg4ff.o
endif

obj-$(CONFIG_HID_3M_PCT) += hid-3m-pct.o
--
1.7.3.1.104.gc752e

2010-11-06 19:07:35

by Tracey Dent

Subject: [PATCH 2/2] Drivers: hid: usbhid: Makefile: Cleaned up Makefile

Changed Makefile to use <modules>-y instead of <modules>-objs.

Signed-off-by: Tracey Dent <[email protected]>
---
drivers/hid/usbhid/Makefile | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/usbhid/Makefile b/drivers/hid/usbhid/Makefile
index 1329ecb..db3cf31 100644
--- a/drivers/hid/usbhid/Makefile
+++ b/drivers/hid/usbhid/Makefile
@@ -3,15 +3,15 @@
#

# Multipart objects.
-usbhid-objs := hid-core.o hid-quirks.o
+usbhid-y := hid-core.o hid-quirks.o

# Optional parts of multipart objects.

ifeq ($(CONFIG_USB_HIDDEV),y)
- usbhid-objs += hiddev.o
+ usbhid-y += hiddev.o
endif
ifeq ($(CONFIG_HID_PID),y)
- usbhid-objs += hid-pidff.o
+ usbhid-y += hid-pidff.o
endif

obj-$(CONFIG_USB_HID) += usbhid.o
--
1.7.3.1.104.gc752e

2010-11-06 19:57:13

by Dmitry Torokhov

Subject: Re: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile

Hi Tracey,

On Sat, Nov 06, 2010 at 03:07:43PM -0400, Tracey Dent wrote:
> Changed Makefile to use <modules>-y instead of <modules>-objs.
>

Changelog normally should say why something has been done as what has
been done is pretty clear from the patch itself.

Thanks.

--
Dmitry

2010-11-06 20:51:08

by Tracey Dent

Subject: Re: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile

On 11/6/10, Dmitry Torokhov <[email protected]> wrote:
> Hi Tracey,
>
> On Sat, Nov 06, 2010 at 03:07:43PM -0400, Tracey Dent wrote:
>> Changed Makefile to use <modules>-y instead of <modules>-objs.
>>
>
> Changelog normally should say why something has been done as what has
> been done is pretty clear from the patch itself.
>

Do you want me to resend patch with more descriptive changelog?

> Thanks.
>
> --
> Dmitry
>

regards

td

2010-11-07 05:44:29

by Dmitry Torokhov

Subject: Re: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile

On Sat, Nov 06, 2010 at 04:51:05PM -0400, Tracey Dent wrote:
> On 11/6/10, Dmitry Torokhov <[email protected]> wrote:
> > Hi Tracey,
> >
> > On Sat, Nov 06, 2010 at 03:07:43PM -0400, Tracey Dent wrote:
> >> Changed Makefile to use <modules>-y instead of <modules>-objs.
> >>
> >
> > Changelog normally should say why something has been done as what has
> > been done is pretty clear from the patch itself.
> >
>
> Do you want me to resend patch with more descriptive changelog?
>

Yes please.

--
Dmitry