2010-11-11 15:47:55

by Uwe Kleine-König

Subject: [PATCH] mfd/mc13xxx: don't open-code mc13xxx_unlock

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/mfd/mc13xxx-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index a2ac2ed..b9fcaf0 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -749,7 +749,7 @@ static int mc13xxx_probe(struct spi_device *spi)
if (ret) {
err_mask:
err_revision:
- mutex_unlock(&mc13xxx->lock);
+ mc13xxx_unlock(mc13xxx);
dev_set_drvdata(&spi->dev, NULL);
kfree(mc13xxx);
return ret;
--
1.7.2.3

2010-11-26 10:40:48

by Samuel Ortiz

Subject: Re: [PATCH] mfd/mc13xxx: don't open-code mc13xxx_unlock

Hi Uwe,

On Thu, Nov 11, 2010 at 04:47:50PM +0100, Uwe Kleine-K?nig wrote:
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
Looks good, patch applied.

Cheers,
Samuel.


> ---
> drivers/mfd/mc13xxx-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> index a2ac2ed..b9fcaf0 100644
> --- a/drivers/mfd/mc13xxx-core.c
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -749,7 +749,7 @@ static int mc13xxx_probe(struct spi_device *spi)
> if (ret) {
> err_mask:
> err_revision:
> - mutex_unlock(&mc13xxx->lock);
> + mc13xxx_unlock(mc13xxx);
> dev_set_drvdata(&spi->dev, NULL);
> kfree(mc13xxx);
> return ret;
> --
> 1.7.2.3
>

--
Intel Open Source Technology Centre
http://oss.intel.com/