2010-12-08 07:22:12

by Namhyung Kim

[permalink] [raw]
Subject: [PATCH] select: remove unused MAX_SELECT_SECONDS

Remove the leftover from the commit 8ff3e8e85fa6 ("select:
switch select() and poll() over to hrtimers").

Signed-off-by: Namhyung Kim <[email protected]>
Cc: Arjan van de Ven <[email protected]>
---
fs/compat.c | 3 ---
fs/select.c | 3 ---
2 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/fs/compat.c b/fs/compat.c
index eb1740a..4376e07 100644
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -1695,9 +1695,6 @@ int compat_set_fd_set(unsigned long nr, compat_ulong_t __user *ufdset,
* Update: ERESTARTSYS breaks at least the xview clock binary, so
* I'm trying ERESTARTNOHAND which restart only when you want to.
*/
-#define MAX_SELECT_SECONDS \
- ((unsigned long) (MAX_SCHEDULE_TIMEOUT / HZ)-1)
-
int compat_core_sys_select(int n, compat_ulong_t __user *inp,
compat_ulong_t __user *outp, compat_ulong_t __user *exp,
struct timespec *end_time)
diff --git a/fs/select.c b/fs/select.c
index b7b10aa..3ecb12a 100644
--- a/fs/select.c
+++ b/fs/select.c
@@ -515,9 +515,6 @@ int do_select(int n, fd_set_bits *fds, struct timespec *end_time)
* Update: ERESTARTSYS breaks at least the xview clock binary, so
* I'm trying ERESTARTNOHAND which restart only when you want to.
*/
-#define MAX_SELECT_SECONDS \
- ((unsigned long) (MAX_SCHEDULE_TIMEOUT / HZ)-1)
-
int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp,
fd_set __user *exp, struct timespec *end_time)
{
--
1.7.3.3.398.g0b0cd.dirty


2010-12-08 18:46:39

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [PATCH] select: remove unused MAX_SELECT_SECONDS

On 12/7/2010 10:53 PM, Namhyung Kim wrote:
> Remove the leftover from the commit 8ff3e8e85fa6 ("select:
> switch select() and poll() over to hrtimers").

fair enough

Acked-by: Arjan van de Ven <[email protected]>