hello.
I have fixed several issues with checkpatch.pl
fixes include standards and format issues.
i have attached the patch along with this mail.
--
software engineer.
department of computer science
rajagiri school of engineering and technology.
On Thu, Dec 9, 2010 at 9:31 AM, Jeffrin Jose <[email protected]> wrote:
> hello.
>
> I have fixed several issues with checkpatch.pl
> fixes include standards and format issues.
>
> i have attached the patch along with this mail.
Please send the patch as inline text in the email as per
Documentation/SubmittingPatches. People are less likely to review your
patches if you send them as attachments.
Pekka
On Thu, Dec 09, 2010 at 01:01:26PM +0530, Jeffrin Jose wrote:
> @@ -152,15 +151,14 @@ extern int msnd_pinnacle_init(void);
> #ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM
> static int preclaim_oss = 1;
> #else
> -static int preclaim_oss = 0;
> +static int preclaim_oss = -1;
You didn't understand that warning, do you?
> @@ -252,8 +248,9 @@ static DEFINE_SPINLOCK(sound_loader_lock);
> * list. Acquires locks as needed
> */
>
> -static int sound_insert_unit(struct sound_unit **list, const struct file_operations *fops, int index, int low, int top, const char *name, umode_t mode, struct device *dev)
> -{
> +static int sound_insert_unit(struct sound_unit **list, const struct \
> +file_operations *fops, int index, int low, int top, const char *name,\
> +umode_t mode, struct device *dev) {
You're splitting lines in unexpected places, so unexpected, that nobody
thought of them before.