2011-02-04 12:23:20

by Vasily Kulikov

Subject: [PATCH 01/20] mach-omap2: mux: world-writable debugfs files

Do not create mux debugfs files as world-writable.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
Cannot compile the driver, so it is not tested at all.

arch/arm/mach-omap2/mux.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 98148b6..6c84659 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -605,7 +605,7 @@ static void __init omap_mux_dbg_create_entry(
list_for_each_entry(e, &partition->muxmodes, node) {
struct omap_mux *m = &e->mux;

- (void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir,
+ (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir,
m, &omap_mux_dbg_signal_fops);
}
}
--
1.7.0.4

2011-02-04 20:10:22

by Tony Lindgren

Subject: Re: [PATCH 01/20] mach-omap2: mux: world-writable debugfs files

* Vasiliy Kulikov <[email protected]> [110204 04:21]:
> Do not create mux debugfs files as world-writable.
>
> Signed-off-by: Vasiliy Kulikov <[email protected]>
> ---
> Cannot compile the driver, so it is not tested at all.

Thanks, will queue this as a fix for the -rc cycle.

Tony

> arch/arm/mach-omap2/mux.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 98148b6..6c84659 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -605,7 +605,7 @@ static void __init omap_mux_dbg_create_entry(
> list_for_each_entry(e, &partition->muxmodes, node) {
> struct omap_mux *m = &e->mux;
>
> - (void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir,
> + (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir,
> m, &omap_mux_dbg_signal_fops);
> }
> }
> --
> 1.7.0.4
>