2011-02-21 03:51:07

by Lai Jiangshan

Subject: [PATCH] kvm: better readability of efer_reserved_bits

use EFER_SCE, EFER_LME and EFER_LMA instead of magic numbers.

Signed-off-by: Lai Jiangshan <[email protected]>
---
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index bcc0efc..9d1d3f2 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -81,9 +81,10 @@
* - enable LME and LMA per default on 64 bit KVM
*/
#ifdef CONFIG_X86_64
-static u64 __read_mostly efer_reserved_bits = 0xfffffffffffffafeULL;
+static
+u64 __read_mostly efer_reserved_bits = ~((u64)(EFER_SCE | EFER_LME | EFER_LMA));
#else
-static u64 __read_mostly efer_reserved_bits = 0xfffffffffffffffeULL;
+static u64 __read_mostly efer_reserved_bits = ~((u64)EFER_SCE);
#endif

#define VM_STAT(x) offsetof(struct kvm, stat.x), KVM_STAT_VM

2011-02-28 09:21:24

by Avi Kivity

Subject: Re: [PATCH] kvm: better readability of efer_reserved_bits

On 02/21/2011 05:51 AM, Lai Jiangshan wrote:
> use EFER_SCE, EFER_LME and EFER_LMA instead of magic numbers.
>

Applied, thanks.

--
error compiling committee.c: too many arguments to function