2011-03-16 14:39:16

by Frank Peters

Subject: 2.6.38 Compile Failure e1000e Module

Hello,

I cannot compile kernel 2.6.38. Apparently, there is a build failure
with the e1000e module (ethernet driver). The brief error message is this:

ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

My compiler is gcc-4.5.2 on a Gentoo x64 system. The kernel source
is the stock source from kernel.org.

Please CC to frank.peters (at) comcast.net.

Frank Peters

2011-03-16 15:17:08

by Eric Dumazet

Subject: Re: 2.6.38 Compile Failure e1000e Module

Le mercredi 16 mars 2011 à 10:33 -0400, Frank Peters a écrit :
> Hello,
>
> I cannot compile kernel 2.6.38. Apparently, there is a build failure
> with the e1000e module (ethernet driver). The brief error message is this:
>
> ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> My compiler is gcc-4.5.2 on a Gentoo x64 system. The kernel source
> is the stock source from kernel.org.
>
> Please CC to frank.peters (at) comcast.net.

Hi Franck

Probably coming from commit fe46f58fa61f02
(e1000e: use either_crc_le() rather than re-write it)

Could you try following patch ?

Thanks

[PATCH] e1000e: fix kconfig for crc32 dependency

ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!

Reported-by: Frank Peters <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Bruce Allan <[email protected]>
Cc: Jeff Kirsher <[email protected]>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 0382332..90d1d3c 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2098,6 +2098,7 @@ config E1000

config E1000E
tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
+ select CRC32
depends on PCI && (!SPARC32 || BROKEN)
---help---
This driver supports the PCI-Express Intel(R) PRO/1000 gigabit

2011-03-16 15:21:20

by Randy Dunlap

Subject: [PATCH] net: 2.6.38 Compile Failure e1000e Module

Hi,
Please test this patch:


From: Randy Dunlap <[email protected]>

e1000e needs to select CRC32 for CRC support.
This patch fixes the build error:
ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!

Reported-by: Frank Peters <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- lnx-2638.orig/drivers/net/Kconfig
+++ lnx-2638/drivers/net/Kconfig
@@ -2099,6 +2099,7 @@ config E1000
config E1000E
tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
depends on PCI && (!SPARC32 || BROKEN)
+ select CRC32
---help---
This driver supports the PCI-Express Intel(R) PRO/1000 gigabit
ethernet family of adapters. For PCI or PCI-X e1000 adapters,

2011-03-16 18:10:57

by Frank Peters

Subject: Re: [PATCH] net: 2.6.38 Compile Failure e1000e Module

On Wed, 16 Mar 2011 08:21:05 -0700
Randy Dunlap <[email protected]> wrote:

>
> Please test this patch:
>
> --- lnx-2638.orig/drivers/net/Kconfig
> +++ lnx-2638/drivers/net/Kconfig
> @@ -2099,6 +2099,7 @@ config E1000
> config E1000E
> tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
> depends on PCI && (!SPARC32 || BROKEN)
> + select CRC32
> ---help---
> This driver supports the PCI-Express Intel(R) PRO/1000 gigabit
> ethernet family of adapters. For PCI or PCI-X e1000 adapters,


Yes. The patch works. The 2.6.38 source now builds.

Thanks to all responders.

Frank Peters

2011-03-16 18:14:36

by David Miller

Subject: Re: 2.6.38 Compile Failure e1000e Module

From: Eric Dumazet <[email protected]>
Date: Wed, 16 Mar 2011 16:16:57 +0100

> [PATCH] e1000e: fix kconfig for crc32 dependency
>
> ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!
>
> Reported-by: Frank Peters <[email protected]>
> Signed-off-by: Eric Dumazet <[email protected]>
> Cc: Bruce Allan <[email protected]>
> Cc: Jeff Kirsher <[email protected]>

Applied, thanks Eric.

2011-03-16 18:15:10

by David Miller

Subject: Re: [PATCH] net: 2.6.38 Compile Failure e1000e Module

From: Randy Dunlap <[email protected]>
Date: Wed, 16 Mar 2011 08:21:05 -0700

> Hi,
> Please test this patch:
>
>
> From: Randy Dunlap <[email protected]>
>
> e1000e needs to select CRC32 for CRC support.
> This patch fixes the build error:
> ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!
>
> Reported-by: Frank Peters <[email protected]>
> Signed-off-by: Randy Dunlap <[email protected]>

Randy, I applied Eric Dumazet's copy of this fix only because
his submission preceded your's in terms of time of submission :-)

Thanks!

2011-03-16 18:31:19

by Randy Dunlap

Subject: Re: [PATCH] net: 2.6.38 Compile Failure e1000e Module

On 03/16/11 11:15, David Miller wrote:
> From: Randy Dunlap <[email protected]>
> Date: Wed, 16 Mar 2011 08:21:05 -0700
>
>> Hi,
>> Please test this patch:
>>
>>
>> From: Randy Dunlap <[email protected]>
>>
>> e1000e needs to select CRC32 for CRC support.
>> This patch fixes the build error:
>> ERROR: "crc32_le" [drivers/net/e1000e/e1000e.ko] undefined!
>>
>> Reported-by: Frank Peters <[email protected]>
>> Signed-off-by: Randy Dunlap <[email protected]>
>
> Randy, I applied Eric Dumazet's copy of this fix only because
> his submission preceded your's in terms of time of submission :-)

Ack. :)

thanks,
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***