2011-03-17 01:41:18

by Dave Jones

Subject: fix reversed memset arguments in hv_mouse

size is 3rd arg, not the 2nd.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 50147f8..cbe5686 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -374,7 +374,7 @@ static void MousevscOnReceiveDeviceInfo(struct mousevsc_dev *InputDevice, struct
desc->desc[0].wDescriptorLength);

/* Send the ack */
- memset(&ack, sizeof(struct mousevsc_prt_msg), 0);
+ memset(&ack, 0, sizeof(struct mousevsc_prt_msg));

ack.type = PipeMessageData;
ack.size = sizeof(struct synthhid_device_info_ack);
@@ -595,7 +595,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)
/*
* Now, initiate the vsc/vsp initialization protocol on the open channel
*/
- memset(request, sizeof(struct mousevsc_prt_msg), 0);
+ memset(request, 0, sizeof(struct mousevsc_prt_msg));

request->type = PipeMessageData;
request->size = sizeof(struct synthhid_protocol_request);

2011-03-17 02:04:46

by Greg KH

Subject: Re: fix reversed memset arguments in hv_mouse

On Wed, Mar 16, 2011 at 09:40:59PM -0400, Dave Jones wrote:
> size is 3rd arg, not the 2nd.

Do you just have a script that checks lkml for this? :)

I thought checkpatch.pl caught these problems, I guess not. Thanks for
the patch, I'll queue it up.

greg k-h

2011-03-17 03:06:56

by Dave Jones

Subject: Re: fix reversed memset arguments in hv_mouse

On Wed, Mar 16, 2011 at 07:05:45PM -0700, Greg KH wrote:
> On Wed, Mar 16, 2011 at 09:40:59PM -0400, Dave Jones wrote:
> > size is 3rd arg, not the 2nd.
>
> Do you just have a script that checks lkml for this? :)

mutt hook.

> I thought checkpatch.pl caught these problems, I guess not. Thanks for
> the patch, I'll queue it up.

I thought so too. I'm sure I sent one in. I'll resend it.

Dave