2011-04-02 06:41:46

by Liu Yuan

Subject: [PATCH] drivers, mfd: Remove unused variable 'val'

From: Liu Yuan <[email protected]>


Signed-off-by: Liu Yuan <[email protected]>
---
drivers/mfd/wl1273-core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c
index 04914f2..37af778 100644
--- a/drivers/mfd/wl1273-core.c
+++ b/drivers/mfd/wl1273-core.c
@@ -153,7 +153,6 @@ out:
*/
static int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int volume)
{
- u16 val;
int r;

if (volume > WL1273_MAX_VOLUME)
--
1.7.1

2011-04-16 09:46:52

by Liu Yuan

Subject: Re: [PATCH] drivers, mfd: Remove unused variable 'val'

Hi, Samuel, is there another similar fix already pending? I notice the
latest[ Linus tree[0ebc115da3ed6740, Fri Apr 15 20:31:15 2011 -0700]
still has this redundant variable.

Thanks,
Yuan

On Sat, Apr 2, 2011 at 2:41 PM, Liu Yuan <[email protected]> wrote:
> From: Liu Yuan <[email protected]>
>
>
> Signed-off-by: Liu Yuan <[email protected]>
> ---
>  drivers/mfd/wl1273-core.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c
> index 04914f2..37af778 100644
> --- a/drivers/mfd/wl1273-core.c
> +++ b/drivers/mfd/wl1273-core.c
> @@ -153,7 +153,6 @@ out:
>  */
>  static int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int volume)
>  {
> -       u16 val;
>        int r;
>
>        if (volume > WL1273_MAX_VOLUME)
> --
> 1.7.1
>
>

2011-04-16 13:10:28

by Wanlong Gao

Subject: Re: [PATCH] drivers, mfd: Remove unused variable 'val'

On 4/16/11, Liu Yuan <[email protected]> wrote:
> Hi, Samuel, is there another similar fix already pending? I notice the
> latest[ Linus tree[0ebc115da3ed6740, Fri Apr 15 20:31:15 2011 -0700]
> still has this redundant variable.
>
> Thanks,
> Yuan
>
> On Sat, Apr 2, 2011 at 2:41 PM, Liu Yuan <[email protected]> wrote:
>> From: Liu Yuan <[email protected]>
>>
>>
>> Signed-off-by: Liu Yuan <[email protected]>
>> ---
>> drivers/mfd/wl1273-core.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c
>> index 04914f2..37af778 100644
>> --- a/drivers/mfd/wl1273-core.c
>> +++ b/drivers/mfd/wl1273-core.c
>> @@ -153,7 +153,6 @@ out:
>> */
>> static int wl1273_fm_set_volume(struct wl1273_core *core, unsigned int
>> volume)
>> {
>> - u16 val;
>> int r;
>>
>> if (volume > WL1273_MAX_VOLUME)
Hi Liu Yuan:

It has already fixed in the Samuel's for-next branch.
Cheers .

http://git.kernel.org/?p=linux/kernel/git/sameo/mfd-2.6.git;a=blobdiff;f=drivers/mfd/wl1273-core.c;h=d97a86945174519a6d333bf0527875b63537384d;hp=63d250d9a366aeac9b94ee99bba6b6040f1916f8;hb=f880ff3edc1a6f8cfa98b337dc121824c170164c;hpb=b2b1fc7407b7b989a7582b31e732f81cbc7e1d50
>> --
>> 1.7.1
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>