2011-04-16 15:44:36

by Wanlong Gao

Subject: [PATCH]drivers:regulator:change the dev_dbg in the probe function

From: Wanlong Gao <[email protected]>

change the function name string to "%s".

Signed-off-by: Wanlong Gao <[email protected]>
---
drivers/regulator/mc13783-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index 23249cb..b8a00c7 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct platform_device *pdev)
struct mc13783_regulator_init_data *init_data;
int i, ret;

- dev_dbg(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
+ dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);

priv = kzalloc(sizeof(*priv) +
pdata->num_regulators * sizeof(priv->regulators[0]),
--
1.7.3

2011-04-16 17:54:40

by Mark Brown

Subject: Re: [PATCH]drivers:regulator:change the dev_dbg in the probe function

On Sat, Apr 16, 2011 at 11:42:23PM +0800, [email protected] wrote:

Please ensure that you use subject lines for your patch which fit in
with the style of other changes to the subsystem.

> change the function name string to "%s".

You should also explain why a change is being made, not what the change
is (we can see that from the patch). In this case what you're doing is
making this debug statement be consistent with the style of the rest of
the file.

Acked-by: Mark Brown <[email protected]

2011-04-17 00:54:17

by Wanlong Gao

Subject: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

change the "mc13783_regulator_probe" string in the function
"mc13783_regulator_probe"
to "__func__" for the debug statement be consistent with the style of
the rest of
the file.

Signed-off-by: Wanlong Gao <[email protected]>
Acked-by: Mark Brown <[email protected]>

---
drivers/regulator/mc13783-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/mc13783-regulator.c
b/drivers/regulator/mc13783-regulator.c
index 23249cb..b8a00c7 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct
platform_device *pdev)
struct mc13783_regulator_init_data *init_data;
int i, ret;

- dev_dbg(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
+ dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);

priv = kzalloc(sizeof(*priv) +
pdata->num_regulators *
sizeof(priv->regulators[0]),
--
1.7.3

2011-04-17 09:19:50

by jiaweiwei

Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

On Sun, Apr 17, 2011 at 08:53:57AM +0800, Wanlong Gao wrote:
>
>
> change the "mc13783_regulator_probe" string in the function
> "mc13783_regulator_probe"
> to "__func__" for the debug statement be consistent with the style
> of the rest of
> the file.
>
> Signed-off-by: Wanlong Gao <[email protected]>
> Acked-by: Mark Brown <[email protected]>
Hi Wanlong,
I really wanna know have Mark given this patch a 'Acked-by'.
Because you are the first one, who sent this patch. Of course, Mark
maybe your workmate or else.
I am so sorry for this silly question :) but i am curious
about it.

Thanks.
Harry Wei.

2011-04-17 10:12:18

by Wanlong Gao

Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

2011-4-17 17:19, Harry Wei wrote:
> On Sun, Apr 17, 2011 at 08:53:57AM +0800, Wanlong Gao wrote:
>>
>>
>> change the "mc13783_regulator_probe" string in the function
>> "mc13783_regulator_probe"
>> to "__func__" for the debug statement be consistent with the style
>> of the rest of
>> the file.
>>
>> Signed-off-by: Wanlong Gao<[email protected]>
>> Acked-by: Mark Brown<[email protected]>
> Hi Wanlong,
> I really wanna know have Mark given this patch a 'Acked-by'.
> Because you are the first one, who sent this patch. Of course, Mark
> maybe your workmate or else.
> I am so sorry for this silly question :) but i am curious
> about it.
>
> Thanks.
> Harry Wei.
It just a resend patch which had already acked-by Make.
You had missed my patch before .
Thanks

2011-04-17 10:23:31

by jiaweiwei

Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

On Sun, Apr 17, 2011 at 06:17:54PM +0800, harryxiyou wrote:
> >>> Signed-off-by: Wanlong Gao<[email protected]>
> >>> Acked-by: Mark Brown<[email protected]>
> >>>
> >> Hi Wanlong,
> >> I really wanna know have Mark given this patch a 'Acked-by'.
> >> Because you are the first one, who sent this patch. Of course, Mark
> >> maybe your workmate or else.
> >> I am so sorry for this silly question :) but i am curious
> >> about it.
> >>
> >> Thanks.
> >> Harry Wei.
> >>
> > It just a resend patch which had already acked-by Make.
> > You had missed my patch before .
> > Thanks
Hmmm..., i see.

Thanks.
Harry Wei.

2011-05-10 08:12:26

by Jiri Kosina

Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

On Sun, 17 Apr 2011, Wanlong Gao wrote:

>
>
> change the "mc13783_regulator_probe" string in the function
> "mc13783_regulator_probe"
> to "__func__" for the debug statement be consistent with the style of the rest
> of
> the file.
>
> Signed-off-by: Wanlong Gao <[email protected]>
> Acked-by: Mark Brown <[email protected]>
>
> ---
> drivers/regulator/mc13783-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/mc13783-regulator.c
> b/drivers/regulator/mc13783-regulator.c
> index 23249cb..b8a00c7 100644
> --- a/drivers/regulator/mc13783-regulator.c
> +++ b/drivers/regulator/mc13783-regulator.c
> @@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct
> platform_device *pdev)
> struct mc13783_regulator_init_data *init_data;
> int i, ret;
>
> - dev_dbg(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
> + dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);
>
> priv = kzalloc(sizeof(*priv) +
> pdata->num_regulators * sizeof(priv->regulators[0]),

Applied.

BTW, your mailer is damaging the in-line patches. I have fixed this now,
but please fix that for your future submissions.

Thanks,

--
Jiri Kosina
SUSE Labs

2011-05-10 12:36:49

by Wanlong Gao

Subject: Re: [PATCH] drivers:regulator:change debug statement be consistent with the style of the rest.

在 2011-05-10二的 10:12 +0200，Jiri Kosina写道：
> On Sun, 17 Apr 2011, Wanlong Gao wrote:
>
> >
> >
> > change the "mc13783_regulator_probe" string in the function
> > "mc13783_regulator_probe"
> > to "__func__" for the debug statement be consistent with the style of the rest
> > of
> > the file.
> >
> > Signed-off-by: Wanlong Gao <[email protected]>
> > Acked-by: Mark Brown <[email protected]>
> >
> > ---
> > drivers/regulator/mc13783-regulator.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/regulator/mc13783-regulator.c
> > b/drivers/regulator/mc13783-regulator.c
> > index 23249cb..b8a00c7 100644
> > --- a/drivers/regulator/mc13783-regulator.c
> > +++ b/drivers/regulator/mc13783-regulator.c
> > @@ -341,7 +341,7 @@ static int __devinit mc13783_regulator_probe(struct
> > platform_device *pdev)
> > struct mc13783_regulator_init_data *init_data;
> > int i, ret;
> >
> > - dev_dbg(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
> > + dev_dbg(&pdev->dev, "%s id %d\n", __func__, pdev->id);
> >
> > priv = kzalloc(sizeof(*priv) +
> > pdata->num_regulators * sizeof(priv->regulators[0]),
>
> Applied.
>
> BTW, your mailer is damaging the in-line patches. I have fixed this now,
> but please fix that for your future submissions.
>
> Thanks,
>

Thanks, and I'll fix it next time.

Wanlong Gao