Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
fast. Thanks to Stanislav Brabec.
Signed-off-by: Pavel Machek <[email protected]>
diff --git a/arch/arm/mach-pxa/include/mach/spitz.h b/arch/arm/mach-pxa/include/mach/spitz.h
index 685749a..06b7cbc 100644
--- a/arch/arm/mach-pxa/include/mach/spitz.h
+++ b/arch/arm/mach-pxa/include/mach/spitz.h
@@ -96,7 +96,7 @@
#define SPITZ_SCP_CHRG_ON SCOOP_GPCR_PA13 /* Keep */
#define SPITZ_SCP_MUTE_L SCOOP_GPCR_PA14 /* Low */
#define SPITZ_SCP_MUTE_R SCOOP_GPCR_PA15 /* Low */
-#define SPITZ_SCP_CF_POWER SCOOP_GPCR_PA16 /* Keep */
+#define SPITZ_SCP_CF_POWER SCOOP_GPCR_PA16 /* Low, CF card eats power */
#define SPITZ_SCP_LED_ORANGE SCOOP_GPCR_PA17 /* Keep */
#define SPITZ_SCP_JK_A SCOOP_GPCR_PA18 /* Low */
#define SPITZ_SCP_ADC_TEMP_ON SCOOP_GPCR_PA19 /* Low */
@@ -105,7 +105,7 @@
SPITZ_SCP_MUTE_L | SPITZ_SCP_MUTE_R | \
SPITZ_SCP_CF_POWER | SPITZ_SCP_JK_A | SPITZ_SCP_ADC_TEMP_ON)
#define SPITZ_SCP_IO_OUT (SPITZ_SCP_CHRG_ON | SPITZ_SCP_MUTE_L | SPITZ_SCP_MUTE_R)
-#define SPITZ_SCP_SUS_CLR (SPITZ_SCP_MUTE_L | SPITZ_SCP_MUTE_R | SPITZ_SCP_JK_A | SPITZ_SCP_ADC_TEMP_ON)
+#define SPITZ_SCP_SUS_CLR (SPITZ_SCP_MUTE_L | SPITZ_SCP_MUTE_R | SPITZ_SCP_JK_A | SPITZ_SCP_ADC_TEMP_ON | SPITZ_SCP_CF_POWER)
#define SPITZ_SCP_SUS_SET 0
#define SPITZ_SCP_GPIO_BASE (NR_BUILTIN_GPIO)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pavel Machek wrote:
> Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
> fast. Thanks to Stanislav Brabec.
If you can verify that your card turns off on suspend, then you have my:
Acked-by: Stanislav Brabec <[email protected]>
But I would line to see more aggressive power control, something like
spitz_card_pwr_ctrl() in old kernels - if there is no CF and no
(external) CF card inserted, then SPITZ_SCP_CF_POWER card be turned off.
If they are memory cards, they can be turned off even while idle.
--
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx, ICQ 116020046, xmpp:[email protected]
Hi!
> > Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
> > fast. Thanks to Stanislav Brabec.
>
> If you can verify that your card turns off on suspend, then you have my:
> Acked-by: Stanislav Brabec <[email protected]>
Yes, I checked the LEDs to make sure it is off. It is.
> But I would line to see more aggressive power control, something like
> spitz_card_pwr_ctrl() in old kernels - if there is no CF and no
> (external) CF card inserted, then SPITZ_SCP_CF_POWER card be turned off.
> If they are memory cards, they can be turned off even while idle.
Yes, that would be nice; but this is already good first step.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
> fast. Thanks to Stanislav Brabec.
>
> Signed-off-by: Pavel Machek <[email protected]>
Works on the top of the 3.0-rc2 on my spitz.
Acked-by: Cyril Hrubis <[email protected]>
--
metan