2011-05-24 11:50:22

by Alan Cox

Subject: [PATCH] kernel: fix silly warning

() should be (void)

Signed-off-by: Alan Cox <[email protected]>
---

kernel/watchdog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 6e63097..7daa4b0 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -98,7 +98,7 @@ __setup("nosoftlockup", nosoftlockup_setup);
* the thresholds with a factor: we make the soft threshold twice the amount of
* time the hard threshold is.
*/
-static int get_softlockup_thresh()
+static int get_softlockup_thresh(void)
{
return watchdog_thresh * 2;
}

2011-05-24 19:27:32

by Ingo Molnar

Subject: Re: [PATCH] kernel: fix silly warning

* Alan Cox <[email protected]> wrote:

> () should be (void)
>
> Signed-off-by: Alan Cox <[email protected]>
> ---
>
> kernel/watchdog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 6e63097..7daa4b0 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -98,7 +98,7 @@ __setup("nosoftlockup", nosoftlockup_setup);
> * the thresholds with a factor: we make the soft threshold twice the amount of
> * time the hard threshold is.
> */
> -static int get_softlockup_thresh()
> +static int get_softlockup_thresh(void)

Yeah. This should already be fixed upstream, Linus pushed it out about 12 hours
ago.

Thanks,

Ingo