2011-05-29 17:33:08

by August Lilleaas

[permalink] [raw]
Subject: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

Fixing a deprecation, replacing __attribute__((packed)) with __packed.

Signed-off-by: August Lilleaas <[email protected]>
---
drivers/firewire/net.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index b9762d0..2e988ca 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -73,7 +73,7 @@ struct rfc2734_arp {
__be32 fifo_lo; /* lo 32bits of sender's FIFO addr */
__be32 sip; /* Sender's IP Address */
__be32 tip; /* IP Address of requested hw addr */
-} __attribute__((packed));
+} __packed;

/* This header format is specific to this driver implementation. */
#define FWNET_ALEN 8
@@ -81,7 +81,7 @@ struct rfc2734_arp {
struct fwnet_header {
u8 h_dest[FWNET_ALEN]; /* destination address */
__be16 h_proto; /* packet type ID field */
-} __attribute__((packed));
+} __packed;

/* IPv4 and IPv6 encapsulation header */
struct rfc2734_header {
--
1.7.5.2


2011-05-29 21:44:32

by Stefan Richter

[permalink] [raw]
Subject: Re: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

On May 29 August Lilleaas wrote:
> Fixing a deprecation, replacing __attribute__((packed)) with __packed.

Who deprecated it and why?

Shouldn't you add "#include <linux/compiler.h>" now?
--
Stefan Richter
-=====-==-== -=-= ===-=
http://arcgraph.de/sr/