2011-06-04 07:35:40

by Németh Márton

Subject: [PATCH] x86: cleanup "idle=mwait" removal warning message

From: Márton Németh <[email protected]>

Cleanup the warning message. This will remove the following warning message
when compiling:

* arch/x86/kernel/process.c:645:1: warning: unknown escape sequence '\i'

Signed-off-by: Márton Németh <[email protected]>
---
--- linux-3.0-rc1/arch/x86/kernel/process.c.orig 2011-06-03 23:56:51.000000000 +0200
+++ linux-3.0-rc1/arch/x86/kernel/process.c 2011-06-04 07:23:54.000000000 +0200
@@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
boot_option_idle_override = IDLE_POLL;
} else if (!strcmp(str, "mwait")) {
boot_option_idle_override = IDLE_FORCE_MWAIT;
- WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
+ WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");
} else if (!strcmp(str, "halt")) {
/*
* When the boot option of idle=halt is added, halt is

2011-06-04 08:06:22

by Borislav Petkov

Subject: Re: [PATCH] x86: cleanup "idle=mwait" removal warning message

On Sat, Jun 04, 2011 at 09:35:29AM +0200, Németh Márton wrote:
> From: Márton Németh <[email protected]>
>
> Cleanup the warning message. This will remove the following warning message
> when compiling:
>
> * arch/x86/kernel/process.c:645:1: warning: unknown escape sequence '\i'

Yeah, yours is correct.

But I think we fixed that already in an orchestrated and concentrated
effort of at least 4 people fixing one printk string culminating in
Linus intervening with an evil merge: af0d6a0a

:-)

Keep up the good work, though, the next issue is right around the
corner, I'm sure.

--
Regards/Gruss,
Boris.