2011-06-27 21:44:59

by Peter Foley

Subject: [PATCH] kbuild: silence generated makefile message

This patch silences the make -C /usr/src/git O=/usr/src/git/build/.
message shown when using the generated makefile in KBUILD_OUTDIR.

Signed-off-by: Peter Foley <[email protected]>
---
scripts/mkmakefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/mkmakefile b/scripts/mkmakefile
index 5325423..f4642f2 100644
--- a/scripts/mkmakefile
+++ b/scripts/mkmakefile
@@ -40,7 +40,7 @@ MAKEFLAGS += --no-print-directory
all := \$(filter-out all Makefile,\$(MAKECMDGOALS))

all:
- \$(MAKE) \$(MAKEARGS) \$(all)
+ @\$(MAKE) \$(MAKEARGS) \$(all)

Makefile:;

--
1.7.5.3

2011-06-27 23:01:26

by Arnaud Lacombe

Subject: Re: [PATCH] kbuild: silence generated makefile message

Hi,

On Mon, Jun 27, 2011 at 5:42 PM, Peter Foley <[email protected]> wrote:
>
> This patch silences the make -C /usr/src/git O=/usr/src/git/build/.
> message shown when using the generated makefile in KBUILD_OUTDIR.
>
I would expect verbose build to show that message. not hides it
unconditionally, no ?

- Arnaud

> Signed-off-by: Peter Foley <[email protected]>
> ---
> ?scripts/mkmakefile | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/mkmakefile b/scripts/mkmakefile
> index 5325423..f4642f2 100644
> --- a/scripts/mkmakefile
> +++ b/scripts/mkmakefile
> @@ -40,7 +40,7 @@ MAKEFLAGS += --no-print-directory
> ?all ? ?:= \$(filter-out all Makefile,\$(MAKECMDGOALS))
>
> ?all:
> - ? ? ? \$(MAKE) \$(MAKEARGS) \$(all)
> + ? ? ? @\$(MAKE) \$(MAKEARGS) \$(all)
>
> ?Makefile:;
>
> --
> 1.7.5.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

2011-06-27 23:20:28

by Peter Foley

Subject: Re: [PATCH] kbuild: silence generated makefile message

On Mon, 27 Jun 2011, Arnaud Lacombe wrote:

> Hi,
>
> On Mon, Jun 27, 2011 at 5:42 PM, Peter Foley <[email protected]> wrote:
> >
> > This patch silences the make -C /usr/src/git O=/usr/src/git/build/.
> > message shown when using the generated makefile in KBUILD_OUTDIR.
> >
> I would expect verbose build to show that message. not hides it
> unconditionally, no ?
>
> - Arnaud
>

Good point, I'll fix that.

Thanks,

Peter

2011-06-27 23:37:00

by Peter Foley

Subject: [PATCH V2] kbuild: silence generated makefile message

This patch silences the "make -C /usr/src/git O=/usr/src/git/build/."
message shown when using the generated makefile in KBUILD_OUTDIR.


Signed-off-by: Peter Foley <[email protected]>
---

V2: Show message when V=1

scripts/mkmakefile | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/scripts/mkmakefile b/scripts/mkmakefile
index 5325423..ea26f37 100644
--- a/scripts/mkmakefile
+++ b/scripts/mkmakefile
@@ -30,6 +30,10 @@ PATCHLEVEL = $4
lastword = \$(word \$(words \$(1)),\$(1))
makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST)))

+ifneq (\$(V),1)
+Q := @
+endif
+
MAKEARGS := -C $1
MAKEARGS += O=\$(if \$(patsubst /%,,\$(makedir)),\$(CURDIR)/)\$(patsubst %/,%,\$(makedir))

@@ -40,7 +44,7 @@ MAKEFLAGS += --no-print-directory
all := \$(filter-out all Makefile,\$(MAKECMDGOALS))

all:
- \$(MAKE) \$(MAKEARGS) \$(all)
+ \$(Q)\$(MAKE) \$(MAKEARGS) \$(all)

Makefile:;

--
1.7.5.3