2012-02-07 02:58:33

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the l2-mtd tree

Hi Artem,

After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mtd/devices/pmc551.c: In function 'pmc551_erase':
drivers/mtd/devices/pmc551.c:157:2: error: implicit declaration of function 'pmc551_point' [-Werror=implicit-function-declaration]
drivers/mtd/devices/pmc551.c: At top level:
drivers/mtd/devices/pmc551.c:194:12: error: static declaration of 'pmc551_point' follows non-static declaration
drivers/mtd/devices/pmc551.c:157:2: note: previous implicit declaration of 'pmc551_point' was here
drivers/mtd/devices/pmc551.c: In function 'pmc551_unpoint':
drivers/mtd/devices/pmc551.c:229:1: warning: no return statement in function returning non-void [-Wreturn-type]

Caused by commit 1e43e2c68ec0 ("mtd: remove junk pmc551.h"). The last
warning was already there. Please try to build test this stuff before
publishing ...

I have used the version of the l2-mtd tree from next-20120203 for today.
--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (1.00 kB)
(No filename) (836.00 B)
Download all attachments

2012-02-07 08:00:06

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the l2-mtd tree

On Tue, 2012-02-07 at 13:58 +1100, Stephen Rothwell wrote:
> Hi Artem,
>
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/mtd/devices/pmc551.c: In function 'pmc551_erase':
> drivers/mtd/devices/pmc551.c:157:2: error: implicit declaration of function 'pmc551_point' [-Werror=implicit-function-declaration]
> drivers/mtd/devices/pmc551.c: At top level:
> drivers/mtd/devices/pmc551.c:194:12: error: static declaration of 'pmc551_point' follows non-static declaration
> drivers/mtd/devices/pmc551.c:157:2: note: previous implicit declaration of 'pmc551_point' was here
> drivers/mtd/devices/pmc551.c: In function 'pmc551_unpoint':
> drivers/mtd/devices/pmc551.c:229:1: warning: no return statement in function returning non-void [-Wreturn-type]

Hi, thanks a lot, I missed this. Fixed and build-tested with ARCH=i386.

--
Best Regards,
Artem Bityutskiy


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part