I have a box where shpc works fine with acpi,
as well as when acpi is not built into kernel,
but fails with acpi=off
Some debugging seems to indicate that
acpi_get_hp_hw_control_from_firmware
fails with acpi=off.
Is this a bug or is there a reason to prevent shpc
from working in this setup?
Do we even care about acpi=off?
Assuming we want to make acpi_get_hp_hw_control_from_firmware
succeed with acpi=off, what is the best way to do this?
Check acpi_pci_disabled?
Thoughts?
--
MST
On Thu, 16 Feb 2012 17:04:22 +0200
"Michael S. Tsirkin" <[email protected]> wrote:
> I have a box where shpc works fine with acpi,
> as well as when acpi is not built into kernel,
> but fails with acpi=off
> Some debugging seems to indicate that
> acpi_get_hp_hw_control_from_firmware
> fails with acpi=off.
>
> Is this a bug or is there a reason to prevent shpc
> from working in this setup?
> Do we even care about acpi=off?
> Assuming we want to make acpi_get_hp_hw_control_from_firmware
> succeed with acpi=off, what is the best way to do this?
> Check acpi_pci_disabled?
Yeah not sure it's important to have SHPC work with acpi=off.
Disabling ACPI prevents us from getting all sorts of important info
these days...
--
Jesse Barnes, Intel Open Source Technology Center