2012-02-19 07:50:21

by Axel Lin

Subject: [PATCH] mfd: tps65912: Initialize irq platform data properly

irq_base of the tps65912 irq platform data should be
initialized with the board provided irq_base data.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mfd/tps65912-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
index 5fec23a..74fd8cb 100644
--- a/drivers/mfd/tps65912-core.c
+++ b/drivers/mfd/tps65912-core.c
@@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
goto err;

init_data->irq = pmic_plat_data->irq;
- init_data->irq_base = pmic_plat_data->irq;
+ init_data->irq_base = pmic_plat_data->irq_base;
ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
if (ret < 0)
goto err;
--
1.7.5.4

2012-02-19 08:05:26

by Hillf Danton

Subject: Re: [PATCH] mfd: tps65912: Initialize irq platform data properly

On Sun, Feb 19, 2012 at 3:50 PM, Axel Lin <[email protected]> wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
>

The description only tells what you did, but why?

> Signed-off-by: Axel Lin <[email protected]>
> ---
>  drivers/mfd/tps65912-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
> index 5fec23a..74fd8cb 100644
> --- a/drivers/mfd/tps65912-core.c
> +++ b/drivers/mfd/tps65912-core.c
> @@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
>                goto err;
>
>        init_data->irq = pmic_plat_data->irq;
> -       init_data->irq_base = pmic_plat_data->irq;
> +       init_data->irq_base = pmic_plat_data->irq_base;
>        ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
>        if (ret < 0)
>                goto err;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>

2012-02-23 16:39:16

by Samuel Ortiz

Subject: Re: [PATCH] mfd: tps65912: Initialize irq platform data properly

Hi Axel,

On Sun, Feb 19, 2012 at 03:50:11PM +0800, Axel Lin wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
Thanks, patch applied to my for-next and for-linus branches.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/