2002-08-08 00:14:28

by john stultz

[permalink] [raw]
Subject: [TRIVIAL][PATCH] cpu_has_tsc cleanup

Marcelo,

Here is a trivial cleanup patch that replaces:
test_bit(X86_FEATURE_TSC, &boot_cpu_data.x86_capability)
w/ the cpu_has_tsc macro.

I believe this was originally by Brian Gerst for 2.5

thanks
-john



Attachments:
linux-2.4.20-pre1_tsc-cleanup_A0.patch (1.24 kB)

2002-08-08 19:53:58

by George Anzinger

[permalink] [raw]
Subject: Re: [TRIVIAL][PATCH] cpu_has_tsc cleanup

john stultz wrote:
>
> Marcelo,
>
> Here is a trivial cleanup patch that replaces:
> test_bit(X86_FEATURE_TSC, &boot_cpu_data.x86_capability)
> w/ the cpu_has_tsc macro.
>
> I believe this was originally by Brian Gerst for 2.5
>
This patch has a problem in the TSC not defined case in that
it access the PIT with out taking the required
locks. spin_lock_irq(&i8253_lock) is used to protect
the PIT...

--
George Anzinger [email protected]
High-res-timers:
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml