2012-05-02 22:39:08

by Hartley Sweeten

Subject: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

Fix the section mismatch be renaming the struct platform_driver
variable.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: MyungJoo Ham <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Kyungmin Park <[email protected]>

---

diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
index 5c0f085..fe7a07b 100644
--- a/drivers/extcon/extcon_gpio.c
+++ b/drivers/extcon/extcon_gpio.c
@@ -153,7 +153,7 @@ static int __devexit gpio_extcon_remove(struct platform_device *pdev)
return 0;
}

-static struct platform_driver gpio_extcon = {
+static struct platform_driver gpio_extcon_driver = {
.probe = gpio_extcon_probe,
.remove = __devexit_p(gpio_extcon_remove),
.driver = {
@@ -162,7 +162,7 @@ static struct platform_driver gpio_extcon = {
},
};

-module_platform_driver(gpio_extcon);
+module_platform_driver(gpio_extcon_driver);

MODULE_AUTHOR("Mike Lockwood <[email protected]>");
MODULE_DESCRIPTION("GPIO extcon driver");

2012-05-02 22:45:17

by Mark Brown

Subject: Re: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

On Wed, May 02, 2012 at 03:38:44PM -0700, H Hartley Sweeten wrote:
> Fix the section mismatch be renaming the struct platform_driver
> variable.

I'm pretty sure I sent a version of this patch sometime last week :/

2012-05-02 22:51:21

by Greg Kroah-Hartman

Subject: Re: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

On Wed, May 02, 2012 at 11:45:14PM +0100, Mark Brown wrote:
> On Wed, May 02, 2012 at 03:38:44PM -0700, H Hartley Sweeten wrote:
> > Fix the section mismatch be renaming the struct platform_driver
> > variable.
>
> I'm pretty sure I sent a version of this patch sometime last week :/

So did I, but I can't seem to find it anywhere. Did I not apply it?

odd.

2012-05-02 23:04:21

by Mark Brown

Subject: Re: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

On Wed, May 02, 2012 at 03:51:15PM -0700, Greg KH wrote:

> So did I, but I can't seem to find it anywhere. Did I not apply it?

> odd.

Nope, no response at all from you that I recall. Perhaps I forgot to CC
the list or something.

2012-05-02 23:10:18

by Hartley Sweeten

Subject: RE: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

On Wednesday, May 02, 2012 3:45 PM, Mark Brown wrote:
> On Wed, May 02, 2012 at 03:38:44PM -0700, H Hartley Sweeten wrote:
>> Fix the section mismatch be renaming the struct platform_driver
>> variable.
>
> I'm pretty sure I sent a version of this patch sometime last week :/

If you have Mark's patch already, I have no problem with you using his
instead.

Regards,
Hartley

2012-05-02 23:21:36

by Greg Kroah-Hartman

Subject: Re: [PATCH] Extcon: fix section mismatch in extcon_gpio.c

On Thu, May 03, 2012 at 12:04:18AM +0100, Mark Brown wrote:
> On Wed, May 02, 2012 at 03:51:15PM -0700, Greg KH wrote:
>
> > So did I, but I can't seem to find it anywhere. Did I not apply it?
>
> > odd.
>
> Nope, no response at all from you that I recall. Perhaps I forgot to CC
> the list or something.

Hm, I found it now, it ended up in my "already applied this" mbox, but
obviously, I didn't apply it.

Very sorry about that, I went through a few hundred patches the other
day on the airplane, I must have messed this one up, my apologies.

greg k-h