2012-06-01 16:55:38

by Borislav Petkov

Subject: [PATCH] init: Drop initcall level output

From: Borislav Petkov <[email protected]>

9fb48c744ba6a ("params: add 3rd arg to option handler callback
signature") added similar lines to dmesg:

initlevel:0=early, 4 registered initcalls
initlevel:1=core, 31 registered initcalls
initlevel:2=postcore, 11 registered initcalls
initlevel:3=arch, 7 registered initcalls
initlevel:4=subsys, 40 registered initcalls
initlevel:5=fs, 30 registered initcalls
initlevel:6=device, 250 registered initcalls
initlevel:7=late, 35 registered initcalls

but they don't contain any info for the general user staring at dmesg.
I'm very doubtful the count of initcalls registered per level helps
anyone so drop that output completely.

Cc: Jim Cromie <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Jason Baron <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
---
init/main.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/init/main.c b/init/main.c
index 1ca6b32c4828..f956829b3add 100644
--- a/init/main.c
+++ b/init/main.c
@@ -755,13 +755,8 @@ static void __init do_initcalls(void)
{
int level;

- for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++) {
- pr_info("initlevel:%d=%s, %d registered initcalls\n",
- level, initcall_level_names[level],
- (int) (initcall_levels[level+1]
- - initcall_levels[level]));
+ for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++)
do_initcall_level(level);
- }
}

/*
--
1.7.9.3.362.g71319

2012-06-04 04:48:42

by Rusty Russell

Subject: Re: [PATCH] init: Drop initcall level output

On Fri, 1 Jun 2012 18:56:00 +0200, Borislav Petkov <[email protected]> wrote:
> From: Borislav Petkov <[email protected]>
>
> 9fb48c744ba6a ("params: add 3rd arg to option handler callback
> signature") added similar lines to dmesg:
>
> initlevel:0=early, 4 registered initcalls
> initlevel:1=core, 31 registered initcalls
> initlevel:2=postcore, 11 registered initcalls
> initlevel:3=arch, 7 registered initcalls
> initlevel:4=subsys, 40 registered initcalls
> initlevel:5=fs, 30 registered initcalls
> initlevel:6=device, 250 registered initcalls
> initlevel:7=late, 35 registered initcalls
>
> but they don't contain any info for the general user staring at dmesg.
> I'm very doubtful the count of initcalls registered per level helps
> anyone so drop that output completely.
>
> Cc: Jim Cromie <[email protected]>
> Cc: Rusty Russell <[email protected]>
> Cc: Jason Baron <[email protected]>
> Signed-off-by: Borislav Petkov <[email protected]>

Agreed and applied.

Thanks!
Rusty.