2012-06-04 15:14:15

by Cyrill Gorcunov

[permalink] [raw]
Subject: Probleam reading fdinfo symlinks after 30a08bf2d31d275c6fc71dd1811342777e95c831

Hi Linus,

just tried 3.5-rc1 out and found that with commit
30a08bf2d31d275c6fc71dd1811342777e95c831 the reading
of fdinfo files returns "Too many levels of symbolic links"
error.

| [root@neptune~]# cat /proc/`pidof crond`/fdinfo/0
| cat: /proc/1417/fdinfo/0: Too many levels of symbolic links

so I reverted it manually and now it works as expected

| [root@neptune ~]# cat /proc/`pidof crond`/fdinfo/0
| pos: 0
| flags: 0100002

I suspect this is unintentional behaviour of the commit.


2012-06-04 17:59:51

by Linus Torvalds

[permalink] [raw]
Subject: Re: Probleam reading fdinfo symlinks after 30a08bf2d31d275c6fc71dd1811342777e95c831

On Mon, Jun 4, 2012 at 8:14 AM, Cyrill Gorcunov <[email protected]> wrote:
>
> just tried 3.5-rc1 out and found that with commit
> 30a08bf2d31d275c6fc71dd1811342777e95c831 the reading
> of fdinfo files returns "Too many levels of symbolic links"
> error.

Ugh. The fdinfo files aren't symlinks at all, and share the revalidate function.

My bad. The fix isn't pretty, but still better than reverting things.
This should fix it.

Linus


Attachments:
patch.diff (1.39 kB)

2012-06-04 18:12:01

by Cyrill Gorcunov

[permalink] [raw]
Subject: Re: Probleam reading fdinfo symlinks after 30a08bf2d31d275c6fc71dd1811342777e95c831

On Mon, Jun 04, 2012 at 10:59:24AM -0700, Linus Torvalds wrote:
> On Mon, Jun 4, 2012 at 8:14 AM, Cyrill Gorcunov <[email protected]> wrote:
> >
> > just tried 3.5-rc1 out and found that with commit
> > 30a08bf2d31d275c6fc71dd1811342777e95c831 the reading
> > of fdinfo files returns "Too many levels of symbolic links"
> > error.
>
> Ugh. The fdinfo files aren't symlinks at all, and share the revalidate function.
>
> My bad. The fix isn't pretty, but still better than reverting things.
> This should fix it.

Thanks Linus! This patch fixed it.

Tested-by: Cyrill Gorcunov <[email protected]>