2002-08-15 10:27:00

by Petr Vandrovec

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] broken cfb* support in the

On 14 Aug 02 at 21:30, James Simmons wrote:
> > Hi Linus, hello others,
> > please apply this.
> >
> > line_length, type and visual moved from display struct to the fb_info's fix
> > structure during last fbdev updates. Unfortunately generic code was not updated
> > together, so now every fbdev driver is broken.
>
> That was done to push people to port there drivers to the new api. I
> applied the patch to the Bk repository but expect more breakage.

Which new API? If you are going to remove logo and unaccelerated fbcon-cfb*,
then remove them completely. If you are not going to remove unaccelerated
fbcon-cfb*, then there is no reason for breaking them.

I'm not going to remove unaccelerated code from the matroxfb. Never.
Petr Vandrovec
[email protected]


2002-08-22 18:35:52

by James Simmons

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] broken cfb* support in the


> Which new API?

The one being worked on for the last 2 years.

> If you are going to remove logo and unaccelerated fbcon-cfb*,
> then remove them completely. If you are not going to remove unaccelerated
> fbcon-cfb*, then there is no reason for breaking them.

The next set of round of changes will will reimplement drawing the penguin
and will support 24 bpp mode. So we will be able to remove fbcon-cfb*
completely the next round.

> I'm not going to remove unaccelerated code from the matroxfb. Never.

Then implement your own soft accel functions.