2012-10-03 02:27:45

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the ubi tree

---

Hi Artem,

After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!

I have used the ubi tree form next-20121002 for today.
--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (418.00 B)
(No filename) (836.00 B)
Download all attachments

2012-10-03 07:20:57

by Artem Bityutskiy

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the ubi tree

---

On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote:
> Hi Artem,
>
> After merging the ubi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!

I've added Richard's fastmap work there. I'll look at these failures.

And yes, using the previous ubi tree is a good decision, thanks!

--
Best Regards,
Artem Bityutskiy

---

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part

2012-10-03 08:31:40

by Richard Weinberger

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the ubi tree

---

Artem, Stephen,

Am Wed, 03 Oct 2012 10:20:43 +0300
schrieb Artem Bityutskiy <[email protected]>:

> On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote:
> > Hi Artem,
> >
> > After merging the ubi tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!
>
> I've added Richard's fastmap work there. I'll look at these failures.

Thanks for reporting this.
I'm not sure why this happens with allmodconfig.
If I set CONFIG_MTD=m and CONFIG_MTD_UBI=m it builds fine,
that's how I did most build tests.

The following patch fixes the issue for me.
Artem, are you fine with it?

Thanks,
//richard

---
diff --git a/drivers/mtd/ubi/Makefile b/drivers/mtd/ubi/Makefile
index 7ab19ac..b46b0c97 100644
--- a/drivers/mtd/ubi/Makefile
+++ b/drivers/mtd/ubi/Makefile
@@ -2,6 +2,6 @@ obj-$(CONFIG_MTD_UBI) += ubi.o

ubi-y += vtbl.o vmt.o upd.o build.o cdev.o kapi.o eba.o io.o wl.o
attach.o ubi-y += misc.o debug.o
+ubi-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o

obj-$(CONFIG_MTD_UBI_GLUEBI) += gluebi.o
-obj-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o