2012-10-16 13:24:17

by Roland Stigge

Subject: [PATCH] gpio-74x164: Fix buffer allocation size

The new registers handling in the gpio-74x164 driver allocates chip->registers
* 8 bytes where only one byte per register is necessary. This patch fixes this.

Signed-off-by: Roland Stigge <[email protected]>
---
drivers/gpio/gpio-74x164.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/drivers/gpio/gpio-74x164.c
+++ linux-2.6/drivers/gpio/gpio-74x164.c
@@ -153,7 +153,7 @@ static int __devinit gen_74x164_probe(st
}

chip->gpio_chip.ngpio = GEN_74X164_NUMBER_GPIOS * chip->registers;
- chip->buffer = devm_kzalloc(&spi->dev, chip->gpio_chip.ngpio, GFP_KERNEL);
+ chip->buffer = devm_kzalloc(&spi->dev, chip->registers, GFP_KERNEL);
if (!chip->buffer) {
ret = -ENOMEM;
goto exit_destroy;

2012-10-16 17:35:23

by Linus Walleij

Subject: Re: [PATCH] gpio-74x164: Fix buffer allocation size

On Tue, Oct 16, 2012 at 3:24 PM, Roland Stigge <[email protected]> wrote:

> The new registers handling in the gpio-74x164 driver allocates chip->registers
> * 8 bytes where only one byte per register is necessary. This patch fixes this.
>
> Signed-off-by: Roland Stigge <[email protected]>

Patch applied to my fixes branch unless someone shouts...

Yours,
Linus Walleij