2012-10-20 18:20:14

by Borislav Petkov

Subject: [PATCH] kvm, svm: Cleanup error statements

Use __func__ instead of the function name in svm_hardware_enable since
those things tend to get out of sync. This also slims down printk line
length in conjunction with using pr_err.

No functionality change.

Cc: Joerg Roedel <[email protected]>
Cc: Avi Kivity <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
---
arch/x86/kvm/svm.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index d017df3899ef..e93908fabf46 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -630,15 +630,12 @@ static int svm_hardware_enable(void *garbage)
return -EBUSY;

if (!has_svm()) {
- printk(KERN_ERR "svm_hardware_enable: err EOPNOTSUPP on %d\n",
- me);
+ pr_err("%s: err EOPNOTSUPP on %d\n", __func__, me);
return -EINVAL;
}
sd = per_cpu(svm_data, me);
-
if (!sd) {
- printk(KERN_ERR "svm_hardware_enable: svm_data is NULL on %d\n",
- me);
+ pr_err("%s: svm_data is NULL on %d\n", __func__, me);
return -EINVAL;
}

--
1.8.0.rc2

2012-10-22 14:05:35

by Avi Kivity

Subject: Re: [PATCH] kvm, svm: Cleanup error statements

On 10/20/2012 08:20 PM, Borislav Petkov wrote:
> Use __func__ instead of the function name in svm_hardware_enable since
> those things tend to get out of sync. This also slims down printk line
> length in conjunction with using pr_err.
>
> No functionality change.
>

Applied, thanks.


--
error compiling committee.c: too many arguments to function