2011-01-18 19:08:23

by Brian Gix

Subject: -DG_DISABLE_DEPRECATED and g_io_channel_*()

Hi All,

There appears to be a number of deprecated g_io_channel_* functions
being called from the bluez tip, which are breaking the build due to
Marcel's latest commit today:

commit effe770cd43cf53fa5842291941dbfc82beab645
Author: Marcel Holtmann <[email protected]>
Date: Tue Jan 18 14:56:31 2011 +0100

Use -DG_DISABLE_DEPRECATED compiler define


Should this commit be backed out until these deprecated usages have been
fixed, or is this the general way that the issue is forced?

Obviously deprecated functions should not be used, but it creates an
unbuildable bluez in the meantime.

--
Brian Gix
[email protected]
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

2011-01-19 12:17:13

by Luiz Augusto von Dentz

Subject: Re: -DG_DISABLE_DEPRECATED and g_io_channel_*()

Hi,

On Wed, Jan 19, 2011 at 1:25 PM, Marcel Holtmann <[email protected]> wrot=
e:
> Hi Brian,
>
>> There appears to be a number of deprecated g_io_channel_* functions
>> being called from the bluez tip, which are breaking the build due to
>> Marcel's latest commit today:
>>
>> commit effe770cd43cf53fa5842291941dbfc82beab645
>> Author: Marcel Holtmann <[email protected]>
>> Date: =A0 Tue Jan 18 14:56:31 2011 +0100
>>
>> =A0 =A0 Use -DG_DISABLE_DEPRECATED compiler define
>>
>>
>> Should this commit be backed out until these deprecated usages have been
>> fixed, or is this the general way that the issue is forced?
>>
>> Obviously deprecated functions should not be used, but it creates an
>> unbuildable bluez in the meantime.
>
> I broke it on purpose to draw some attention to this ;)

I have just send a pull request to fix those problems.


--=20
Luiz Augusto von Dentz
Computer Engineer

2011-01-19 11:25:12

by Marcel Holtmann

Subject: Re: -DG_DISABLE_DEPRECATED and g_io_channel_*()

Hi Brian,

> There appears to be a number of deprecated g_io_channel_* functions
> being called from the bluez tip, which are breaking the build due to
> Marcel's latest commit today:
>
> commit effe770cd43cf53fa5842291941dbfc82beab645
> Author: Marcel Holtmann <[email protected]>
> Date: Tue Jan 18 14:56:31 2011 +0100
>
> Use -DG_DISABLE_DEPRECATED compiler define
>
>
> Should this commit be backed out until these deprecated usages have been
> fixed, or is this the general way that the issue is forced?
>
> Obviously deprecated functions should not be used, but it creates an
> unbuildable bluez in the meantime.

I broke it on purpose to draw some attention to this ;)

Regards

Marcel