2011-02-03 18:43:48

by Bruna Moreira

Subject: [PATCH] Fix invalid read after list concatenation

g_slist_concat uses the items from second list directly so they should
not be freed.
---
attrib/gatt.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/attrib/gatt.c b/attrib/gatt.c
index f3b513e..20bb96f 100644
--- a/attrib/gatt.c
+++ b/attrib/gatt.c
@@ -121,7 +121,6 @@ static void primary_by_uuid_cb(guint8 status, const guint8 *ipdu,
dp->primaries = g_slist_concat(dp->primaries, ranges);

last = g_slist_last(ranges);
- g_slist_free(ranges);
range = last->data;

if (range->end == 0xffff)
--
1.7.0.4

2011-02-04 04:55:27

by Johan Hedberg

Subject: Re: [PATCH] Fix invalid read after list concatenation

Hi Bruna,

On Thu, Feb 03, 2011, Bruna Moreira wrote:
> g_slist_concat uses the items from second list directly so they should
> not be freed.
> ---
> attrib/gatt.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

Pushed upstream. Thanks.

Johan