2011-08-16 09:45:37

by Pavel Raiskup

[permalink] [raw]

Subject: [PATCH 2/8] Missing comma

---

Missing comma in static array chassis_map definition between
"Blade" and "Blade Enclosure" field.

Typing error fixed.

---
plugins/formfactor.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/formfactor.c b/plugins/formfactor.c
index 3b31927..0e19ac6 100644
--- a/plugins/formfactor.c
+++ b/plugins/formfactor.c
@@ -73,10 +73,10 @@ static const char *chassis_map[] = {
"Rack Mount Chassis", "unknown",
"Sealed-case PC", "unknown",
"Multi-system", "unknown",
- "CompactPCI", "unknonw",
+ "CompactPCI", "unknown",
"AdvancedTCA", "unknown",
"Blade", "server",
- "Blade Enclosure" "unknown", /* 0x1D */
+ "Blade Enclosure", "unknown", /* 0x1D */
NULL
};

--
1.7.4.4

2011-08-23 06:06:09

by Pavel Raiskup

[permalink] [raw]

Subject: Re: [PATCH 2/8] Missing comma

---

Hi Lucas,

>> Missing comma in static array chassis_map definition between
>> "Blade" and "Blade Enclosure" field.
>>
>> Typing error fixed.
>>
>> ....
>>
>> - "CompactPCI", "unknonw",
>> + "CompactPCI", "unknown",
>> "AdvancedTCA", "unknown",
>> "Blade", "server",
>> - "Blade Enclosure" "unknown", /* 0x1D */
>> + "Blade Enclosure", "unknown", /* 0x1D */

> Lucas De Marchi wrote:
>
> Nice catch, but because of errors like this, I think it'd be better to
> use a struct with 2 "char *" fields, isn't it?

You are right but anyway is this really necessary to make quite big change
in struct/control code? There is possible to make other "switch-line"
errors when 2 "char *" arrays used.

Attaching previous patch again due to possible corruption by my email
client.

Pavel

---

Attachments:

0002-Missing-comma.patch (982.00 B)

2011-08-16 16:48:38

by Lucas De Marchi

[permalink] [raw]

Subject: Re: [PATCH 2/8] Missing comma

---

On Tue, Aug 16, 2011 at 6:45 AM, Pavel Raiskup <[email protected]> wrote:
> Missing comma in static array chassis_map definition between
> "Blade" and "Blade Enclosure" field.
>
> Typing error fixed.
>
> ---
> ?plugins/formfactor.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugins/formfactor.c b/plugins/formfactor.c
> index 3b31927..0e19ac6 100644
> --- a/plugins/formfactor.c
> +++ b/plugins/formfactor.c
> @@ -73,10 +73,10 @@ static const char *chassis_map[] = {
> ? ? ? ?"Rack Mount Chassis", ? ?"unknown",
> ? ? ? ?"Sealed-case PC", ? ? ? ?"unknown",
> ? ? ? ?"Multi-system", ? ? ? ? ?"unknown",
> - ? ? ? "CompactPCI", ? ? ? ? ? ?"unknonw",
> + ? ? ? "CompactPCI", ? ? ? ? ? ?"unknown",
> ? ? ? ?"AdvancedTCA", ? ? ? ? ? "unknown",
> ? ? ? ?"Blade", ? ? ? ? ? ? ? ? "server",
> - ? ? ? "Blade Enclosure" ? ? ? ?"unknown", /* 0x1D */
> + ? ? ? "Blade Enclosure", ? ? ? "unknown", /* 0x1D */
> ? ? ? ?NULL
> ?};

Nice catch, but because of errors like this, I think it'd be better to
use a struct with 2 "char *" fields, isn't it?


Lucas De Marchi