2011-08-12 13:18:48

by Slawomir Bochenski

Subject: [PATCH obexd] phonebook-tracker.c: Calls query speed-up

Another change regarding performance of call history queries. This makes
them non-sensitive (in terms of speed) to the corner case situations when
there are hundreds of contacts all having the same phone number.
---
plugins/phonebook-tracker.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index 8bc070f..875901c 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -164,7 +164,7 @@
"?_unb_contact nco:hasPhoneNumber ?_cpn . " \
CONSTRAINT \
"OPTIONAL { " \
- "{ SELECT ?_contact ?_cpn ?_role ?_number " \
+ "{ SELECT ?_contact ?_no ?_role ?_number " \
"count(?_contact) as ?cnt " \
"WHERE { " \
"?_contact a nco:PersonContact . " \
@@ -175,9 +175,9 @@ CONSTRAINT \
"?_contact nco:hasPhoneNumber ?_number" \
"} " \
"?_number maemo:localPhoneNumber ?_no . " \
- "?_cpn maemo:localPhoneNumber ?_no . " \
- "} GROUP BY ?_cpn } " \
+ "} GROUP BY ?_no } " \
"FILTER(?cnt = 1) " \
+ "?_cpn maemo:localPhoneNumber ?_no . " \
"} " \
"} "

--
1.7.4.1

2011-08-22 07:40:04

by Johan Hedberg

Subject: Re: [PATCH obexd] phonebook-tracker.c: Calls query speed-up

Hi Slawek,

On Fri, Aug 12, 2011, Slawomir Bochenski wrote:
> Another change regarding performance of call history queries. This
> makes them non-sensitive (in terms of speed) to the corner case
> situations when there are hundreds of contacts all having the same
> phone number.
> ---
> plugins/phonebook-tracker.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

Applied. Thanks.

Johan