2012-01-24 13:22:43

by Slawomir Bochenski

Subject: [PATCH BlueZ] lib/sdp.c: Prevent passing unitialised argument

In case of sdp_seq_alloc() failures in loop, unitialised seqDTDs would
be passed to final sdp_seq_alloc.
---
lib/sdp.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/sdp.c b/lib/sdp.c
index a48ee14..f618252 100644
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -2523,11 +2523,15 @@ int sdp_set_profile_descs(sdp_record_t *rec, const sdp_list_t *profiles)
dtds[1] = &uint16;
values[1] = &profile->version;
seq = sdp_seq_alloc(dtds, values, 2);
- if (seq) {
- seqDTDs[i] = &seq->dtd;
- seqs[i] = seq;
- sdp_pattern_add_uuid(rec, &profile->uuid);
+
+ if (seq == NULL) {
+ status = -1;
+ break;
}
+
+ seqDTDs[i] = &seq->dtd;
+ seqs[i] = seq;
+ sdp_pattern_add_uuid(rec, &profile->uuid);
i++;
}
if (status == 0) {
--
1.7.4.1

2012-06-28 10:51:27

by Johan Hedberg

Subject: Re: [PATCH BlueZ] lib/sdp.c: Prevent passing unitialised argument

Hi Slawek,

On Tue, Jan 24, 2012, Slawomir Bochenski wrote:
> In case of sdp_seq_alloc() failures in loop, unitialised seqDTDs would
> be passed to final sdp_seq_alloc.
> ---
> lib/sdp.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)

Applied. Thanks.

Johan