2012-06-12 01:13:38

by Paulo Alcantara

Subject: [PATCH] Bluetooth: Remove magic value in disconnect mgmt handler

This patch replaces the magic value of variable 'reason' by the
proper macro.

Signed-off-by: Paulo Alcantara <[email protected]>
---
net/bluetooth/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 5903d3b..00c9ec1 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -1557,7 +1557,7 @@ static int unpair_device(struct sock *sk, struct hci_dev *hdev, void *data,
}

dc.handle = cpu_to_le16(conn->handle);
- dc.reason = 0x13; /* Remote User Terminated Connection */
+ dc.reason = HCI_ERROR_REMOTE_USER_TERM;
err = hci_send_cmd(hdev, HCI_OP_DISCONNECT, sizeof(dc), &dc);
if (err < 0)
mgmt_pending_remove(cmd);
--
1.7.10.2

2012-06-12 01:20:42

by Paulo Alcantara

Subject: Re: [PATCH] Bluetooth: Remove magic value in disconnect mgmt handler

From: Paulo Alcantara <[email protected]>
Date: Mon, 11 Jun 2012 22:13:38 -0300

> This patch replaces the magic value of variable 'reason' by the
> proper macro.
>
> Signed-off-by: Paulo Alcantara <[email protected]>
> ---
> net/bluetooth/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Ignore this patch. The commit message is wrong.

The correct one is: "[PATCH v2] Bluetooth: Remove magic value in unpair_device
handler".

Thanks,

Paulo